Skip to content

Conversation

@rk295
Copy link
Contributor

@rk295 rk295 commented Jan 16, 2026

Description

Closes #1353.

Add the ec2:DescribeTags permission needed by the monitor_runner.sh script.

Migrations required

No, although users who have potentially worked around this bug would be wise to remove their workarounds and let the module handle this.

Verification

Built a fleeting rig and observed the monitor_runner.sh script does not exit with permission denied when listing the tags.

@rk295 rk295 requested review from kayman-mk and npalm as code owners January 16, 2026 09:15
@github-actions
Copy link
Contributor

Hey @rk295! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@rk295 rk295 changed the title Add the permissions neeed by monitor_runner.sh (closes #1353) fix: Add the permissions neeed by monitor_runner.sh (closes #1353) Jan 16, 2026
@rk295 rk295 changed the title fix: Add the permissions neeed by monitor_runner.sh (closes #1353) fix: add the permissions neeed by monitor_runner.sh (closes #1353) Jan 16, 2026
@rk295
Copy link
Contributor Author

rk295 commented Jan 16, 2026

From a new user experience pov it would save compute resources and time if the PR title linter reported all problems in one run, rather than reporting about one at a time.

I'm not sure if that's something the tool supports that could be fixed in the CI in this project or would require upstream to add support but it would definitely save wasting resources and produce a nicer user experience.

@kayman-mk kayman-mk changed the title fix: add the permissions neeed by monitor_runner.sh (closes #1353) fix: add the permissions neeed by monitor_runner.sh Jan 17, 2026
@kayman-mk
Copy link
Collaborator

From a new user experience pov it would save compute resources and time if the PR title linter reported all problems in one run, rather than reporting about one at a time.

I'm not sure if that's something the tool supports that could be fixed in the CI in this project or would require upstream to add support but it would definitely save wasting resources and produce a nicer user experience.

Absolutely. I check the documentation of the action but didn't found any setting. Could you please create an issue here?

Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But need a link to this monitoring script.

@rk295
Copy link
Contributor Author

rk295 commented Jan 19, 2026

The monitoring script is here in the gitlab-runner.tftpl file. Line 19 of the script, line 339 of the template.

@rk295
Copy link
Contributor Author

rk295 commented Jan 19, 2026

From a new user experience pov it would save compute resources and time if the PR title linter reported all problems in one run, rather than reporting about one at a time.
I'm not sure if that's something the tool supports that could be fixed in the CI in this project or would require upstream to add support but it would definitely save wasting resources and produce a nicer user experience.

Absolutely. I check the documentation of the action but didn't found any setting. Could you please create an issue here?

Will do, thanks for checking the docs!

@kayman-mk kayman-mk merged commit 5496d4f into cattle-ops:main Jan 22, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ec2:DescribeTags missing from permission breaks monitor_runner.sh

2 participants