-
-
Notifications
You must be signed in to change notification settings - Fork 352
fix: add the permissions neeed by monitor_runner.sh
#1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @rk295! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
|
From a new user experience pov it would save compute resources and time if the PR title linter reported all problems in one run, rather than reporting about one at a time. I'm not sure if that's something the tool supports that could be fixed in the CI in this project or would require upstream to add support but it would definitely save wasting resources and produce a nicer user experience. |
monitor_runner.sh
Absolutely. I check the documentation of the action but didn't found any setting. Could you please create an issue here? |
kayman-mk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But need a link to this monitoring script.
|
The monitoring script is here in the |
Will do, thanks for checking the docs! |
Description
Closes #1353.
Add the
ec2:DescribeTagspermission needed by the monitor_runner.sh script.Migrations required
No, although users who have potentially worked around this bug would be wise to remove their workarounds and let the module handle this.
Verification
Built a fleeting rig and observed the
monitor_runner.shscript does not exit with permission denied when listing the tags.