Skip to content

Commit 23cc0b4

Browse files
[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (elastic#209978)
Closes elastic/prodfiler#4386 ### Summary The flyout for the root block always contains the hint "Missing symbols error" because there are no symbols for the root block. We should not show it here. ### What was done Added a condition to not render the callout when frameType is root Before ![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f) After Waiting for [this PR](elastic/elasticsearch#119115) to be merged for the condition to work (cherry picked from commit 9e65d7a)
1 parent d7a6fdc commit 23cc0b4

File tree

1 file changed

+4
-2
lines changed
  • x-pack/solutions/observability/plugins/profiling/public/components/frame_information_window

1 file changed

+4
-2
lines changed

x-pack/solutions/observability/plugins/profiling/public/components/frame_information_window/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
EuiTitle,
1717
} from '@elastic/eui';
1818
import { i18n } from '@kbn/i18n';
19-
import { FrameSymbolStatus, getFrameSymbolStatus } from '@kbn/profiling-utils';
19+
import { FrameSymbolStatus, FrameType, getFrameSymbolStatus } from '@kbn/profiling-utils';
2020
import { isEmpty } from 'lodash';
2121
import React, { useState } from 'react';
2222
import { useCalculateImpactEstimate } from '../../hooks/use_calculate_impact_estimates';
@@ -159,7 +159,9 @@ export function FrameInformationWindow({
159159
</EuiFlexGroup>
160160
</EuiFlexItem>
161161
<FrameInformationAIAssistant frame={frame} />
162-
{showSymbolsStatus && symbolStatus !== FrameSymbolStatus.SYMBOLIZED ? (
162+
{showSymbolsStatus &&
163+
symbolStatus !== FrameSymbolStatus.SYMBOLIZED &&
164+
frame.frameType < FrameType.Root ? (
163165
<EuiFlexItem>
164166
<MissingSymbolsCallout frameType={frame.frameType} />
165167
</EuiFlexItem>

0 commit comments

Comments
 (0)