Merge pull request #7 from caxy/fix-empty_special_case_tags

mgersten-caxy · mgersten-caxy · commit 2ce21c45b0dc · 2014-08-12T13:11:18.000-05:00
Fix error caused when passing empty array into setSpecialCaseTags
diff --git a/lib/Caxy/HtmlDiff/HtmlDiff.php b/lib/Caxy/HtmlDiff/HtmlDiff.php
@@ -67,9 +67,7 @@ public function removeSpecialCaseChar($char)
 
     public function setSpecialCaseTags(array $tags = array())
     {
-        if (!empty($tags)) {
-            $this->specialCaseTags = $tags;
-        }
+        $this->specialCaseTags = $tags;
 
         foreach ($this->specialCaseTags as $tag) {
             $this->addSpecialCaseTag($tag);

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,7 @@ public function removeSpecialCaseChar($char)`
`67`	`67`
`68`	`68`	`public function setSpecialCaseTags(array $tags = array())`
`69`	`69`	`{`
`70`		`- if (!empty($tags)) {`
`71`		`- $this->specialCaseTags = $tags;`
`72`		`- }`
	`70`	`+ $this->specialCaseTags = $tags;`
`73`	`71`
`74`	`72`	`foreach ($this->specialCaseTags as $tag) {`
`75`	`73`	`$this->addSpecialCaseTag($tag);`