Skip to content

Commit 8fc7f99

Browse files
committed
Remove todos
1 parent a071252 commit 8fc7f99

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

lib/Caxy/HtmlDiff/Table/TableDiff.php

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,8 @@
77
use Caxy\HtmlDiff\Operation;
88

99
/**
10-
* @todo Add getters to TableMatch entity
11-
* @todo Move applicable functions to new table classes
12-
* @todo find matches of row/cells in order to handle row/cell additions/deletions
13-
* @todo clean up way to iterate between new and old cells
14-
* @todo Make sure diffed table keeps <tbody> or other table structure elements
15-
* @todo Encoding
10+
* Class TableDiff
11+
* @package Caxy\HtmlDiff\Table
1612
*/
1713
class TableDiff extends AbstractDiff
1814
{
@@ -321,8 +317,6 @@ protected function diffRows($oldRow, $newRow, array &$appliedRowSpans, $forceExp
321317
$expandCells = array();
322318
$cellsWithMultipleRows = array();
323319

324-
// @todo: Do cell matching
325-
326320
$newCellCount = count($newCells);
327321
while ($position->getIndexInNew() < $newCellCount) {
328322
if (!$position->areColumnsEqual()) {
@@ -351,8 +345,6 @@ protected function diffRows($oldRow, $newRow, array &$appliedRowSpans, $forceExp
351345
$extraRow = $this->diffDom->importNode($rowToClone->getDomNode()->cloneNode(false), false);
352346
}
353347

354-
// @todo: How do we handle cells that have both rowspan and colspan?
355-
356348
if ($oldCell->getColspan() > $newCell->getColspan()) {
357349
$this->diffCellsAndIncrementCounters(
358350
$oldCell,

0 commit comments

Comments
 (0)