Skip to content

Commit c946d79

Browse files
author
Sven Hagemann
committed
Removed PHPSimpleXML dependency
It is not used anymore since ListDiff get ported to DOMDocument, so we can get rid of it
1 parent b395cbc commit c946d79

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,8 @@ php-htmldiff is available under [GNU General Public License, version 2][gnu]. Se
199199
* Performance improvements (we have 1 benchmark test, we should probably get more)
200200
* Algorithm improvements - trimming alike text at start and ends, store nested diff results in memory to re-use (like we do w/ caching)
201201
* Benchmark using DOMDocument vs. alternatives vs. string parsing
202+
* Consider not using string parsing for HtmlDiff in order to avoid having to create many DOMDocument instances in ListDiff and TableDiff
202203
* Benchmarking
203-
* Look into removing dependency on php-simple-html-dom-parser library - possibly find alternative or no library at all. Consider how this affects performance.
204204
* Refactoring (but... tests first)
205205
* Overall design/architecture improvements
206206
* API improvements so a new HtmlDiff isn't required for each new diff (especially so that configuration can be re-used)

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
"require": {
2222
"php": ">=7.3",
2323
"ezyang/htmlpurifier": "^4.7",
24-
"kub-at/php-simple-html-dom-parser": "^1.7"
24+
"ext-dom": "*",
25+
"ext-mbstring": "*"
2526
},
2627
"require-dev": {
2728
"phpunit/phpunit": "~9.0",

0 commit comments

Comments
 (0)