Skip to content

Commit fe2ff4f

Browse files
committed
Additional clean-up to remove unused params
1 parent 508fe6d commit fe2ff4f

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lib/Caxy/HtmlDiff/Table/TableDiff.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,11 @@ protected function diffTableRowsWithMatches($oldRows, $newRows, $matches)
248248
break;
249249

250250
case 'delete':
251-
$this->processDeleteOperation($operation, $oldRows, $newRows, $appliedRowSpans);
251+
$this->processDeleteOperation($operation, $oldRows, $appliedRowSpans);
252252
break;
253253

254254
case 'insert':
255-
$this->processInsertOperation($operation, $oldRows, $newRows, $appliedRowSpans);
255+
$this->processInsertOperation($operation, $newRows, $appliedRowSpans);
256256
break;
257257

258258
case 'replace':
@@ -262,23 +262,23 @@ protected function diffTableRowsWithMatches($oldRows, $newRows, $matches)
262262
}
263263
}
264264

265-
protected function processInsertOperation(Operation $operation, $oldRows, $newRows, &$appliedRowSpans, $forceExpansion = false)
265+
protected function processInsertOperation(Operation $operation, $newRows, &$appliedRowSpans, $forceExpansion = false)
266266
{
267267
$targetRows = array_slice($newRows, $operation->startInNew, $operation->endInNew - $operation->startInNew);
268268
foreach ($targetRows as $row) {
269269
$this->diffAndAppendRows(null, $row, $appliedRowSpans, $forceExpansion);
270270
}
271271
}
272272

273-
protected function processDeleteOperation($operation, $oldRows, $newRows, &$appliedRowSpans, $forceExpansion = false)
273+
protected function processDeleteOperation(Operation $operation, $oldRows, &$appliedRowSpans, $forceExpansion = false)
274274
{
275275
$targetRows = array_slice($oldRows, $operation->startInOld, $operation->endInOld - $operation->startInOld);
276276
foreach ($targetRows as $row) {
277277
$this->diffAndAppendRows($row, null, $appliedRowSpans, $forceExpansion);
278278
}
279279
}
280280

281-
protected function processEqualOperation($operation, $oldRows, $newRows, &$appliedRowSpans)
281+
protected function processEqualOperation(Operation $operation, $oldRows, $newRows, &$appliedRowSpans)
282282
{
283283
$targetOldRows = array_values(array_slice($oldRows, $operation->startInOld, $operation->endInOld - $operation->startInOld));
284284
$targetNewRows = array_values(array_slice($newRows, $operation->startInNew, $operation->endInNew - $operation->startInNew));
@@ -292,10 +292,10 @@ protected function processEqualOperation($operation, $oldRows, $newRows, &$appli
292292
}
293293
}
294294

295-
protected function processReplaceOperation($operation, $oldRows, $newRows, &$appliedRowSpans)
295+
protected function processReplaceOperation(Operation $operation, $oldRows, $newRows, &$appliedRowSpans)
296296
{
297-
$this->processDeleteOperation($operation, $oldRows, $newRows, $appliedRowSpans, true);
298-
$this->processInsertOperation($operation, $oldRows, $newRows, $appliedRowSpans, true);
297+
$this->processDeleteOperation($operation, $oldRows, $appliedRowSpans, true);
298+
$this->processInsertOperation($operation, $newRows, $appliedRowSpans, true);
299299
}
300300

301301
protected function getRowMatches($oldMatchData, $newMatchData)

0 commit comments

Comments
 (0)