Fixed issue where the differ crashed when comparing two table columns containing a regular space character (#55)

Author: Sven Hagemann

lib/Caxy/HtmlDiff/Table/TableDiff.php

@@ -733,7 +733,7 @@ protected function htmlFromNode($node)
     protected function setInnerHtml($node, $html)
     {
         // DOMDocument::loadHTML does not allow empty strings.
-        if (strlen($html) === 0) {
+        if (strlen(trim($html)) === 0) {
             $html = '<span class="empty"></span>';
         }
 

tests/fixtures/HtmlDiff/table-whitespace-issue.html

@@ -0,0 +1,29 @@
+<oldText>
+    <table class="Standaardtabel">
+        <tbody>
+        <tr>
+            <td> </td>
+            <td>DDD</td>
+            <td>ABC</td>
+            <td>DEF</td>
+        </tr>
+        </tbody>
+    </table>
+</oldText>
+
+<newText>
+    <table class="Standaardtabel">
+        <tbody>
+        <tr>
+            <td> </td>
+            <td>ZXY</td>
+            <td>ABC</td>
+            <td>DEF</td>
+        </tr>
+        </tbody>
+    </table>
+</newText>
+
+<expected>
+    <table class="Standaardtabel"><tr><td rowspan="1" colspan="1"><span class="empty"></span></td><td rowspan="1" colspan="1"><del class="diffmod">DDD </del><ins class="diffmod">ZXY </ins></td><td rowspan="1" colspan="1"><p>ABC</p></td><td rowspan="1" colspan="1"><p>DEF</p></td></tr></table>
+</expected>