Feature/processing optimizations (Dash-Industry-Forum#4609)

* Remove EssentialProperty from ObjectIron RepresentationMap and account for EssentialProperties not automatically being mapped to Representation

* Remove SupplementalProperty from ObjectIron RepresentationMap and account for SupplementalProperty not automatically being mapped to Representation

* Adjust the Karma config for unit tests to derive code coverage

* Fix a bug that causes SegmentBase playback to crash

Author: dsilhavy

package-lock.json

@@ -33,6 +33,7 @@
     "@chiragrupani/karma-chromium-edge-launcher": "^2.4.1",
     "@eslint/js": "^9.13.0",
     "babel-loader": "^9.1.3",
+    "babel-plugin-istanbul": "^7.0.0",
     "chai": "^4.4.1",
     "chai-spies": "^1.1.0",
     "clean-jsdoc-theme": "^4.2.17",

package.json

@@ -387,6 +387,19 @@ function DashAdapter() {
         return dashManifestModel.getProducerReferenceTimesForAdaptation(realAdaptation);
     }
 
+    /**
+     * Return all EssentialProperties of an AdaptationSet
+     * @param {object} adaptationSet
+     * @return {array}
+     */
+    function getEssentialPropertiesForAdaptationSet(adaptationSet) {
+        try {
+            return dashManifestModel.getEssentialPropertiesForRepresentation(adaptationSet);
+        } catch (e) {
+            return [];
+        }
+    }
+
     /**
      * Return all EssentialProperties of a Representation
      * @param {object} representation
@@ -1013,15 +1026,8 @@ function DashAdapter() {
         }
 
         mediaInfo.isText = dashManifestModel.getIsText(realAdaptation);
-        mediaInfo.essentialProperties = dashManifestModel.getEssentialPropertiesForAdaptation(realAdaptation);
-        if ((!mediaInfo.essentialProperties || mediaInfo.essentialProperties.length === 0) && realAdaptation.Representation && realAdaptation.Representation.length > 0) {
-            mediaInfo.essentialProperties = _getCommonRepresentationEssentialProperties(realAdaptation);
-        }
+        mediaInfo.essentialProperties = dashManifestModel.getEssentialPropertiesForAdaptationSet(realAdaptation);
         mediaInfo.supplementalProperties = dashManifestModel.getSupplementalPropertiesForAdaptation(realAdaptation);
-        if ((!mediaInfo.supplementalProperties || mediaInfo.supplementalProperties.length === 0) && realAdaptation.Representation && realAdaptation.Representation.length > 0) {
-            mediaInfo.supplementalProperties = _getCommonRepresentationSupplementalProperties(realAdaptation);
-        }
-
         mediaInfo.isFragmented = dashManifestModel.getIsFragmented(realAdaptation);
         mediaInfo.isEmbedded = false;
         mediaInfo.adaptationSetSwitchingCompatibleIds = _getAdaptationSetSwitchingCompatibleIds(mediaInfo);
@@ -1080,32 +1086,6 @@ function DashAdapter() {
         return normalizedKeyIds
     }
 
-    function _getCommonRepresentationEssentialProperties(realAdaptation) {
-        let arr = realAdaptation.Representation.map(repr => {
-            return dashManifestModel.getEssentialPropertiesForRepresentation(repr);
-        });
-
-        if (arr.every(v => JSON.stringify(v) === JSON.stringify(arr[0]))) {
-            // only output Representation.essentialProperties to mediaInfo, if they are present on all Representations
-            return arr[0];
-        }
-
-        return []
-    }
-
-    function _getCommonRepresentationSupplementalProperties(realAdaptation) {
-        let arr = realAdaptation.Representation.map(repr => {
-            return dashManifestModel.getSupplementalPropertiesForRepresentation(repr);
-        });
-
-        if (arr.every(v => JSON.stringify(v) === JSON.stringify(arr[0]))) {
-            // only output Representation.supplementalProperties to mediaInfo, if they are present on all Representations
-            return arr[0];
-        }
-
-        return []
-    }
-
     function _getAdaptationSetSwitchingCompatibleIds(mediaInfo) {
         if (!mediaInfo || !mediaInfo.supplementalProperties) {
             return []
@@ -1228,6 +1208,7 @@ function DashAdapter() {
         getCodec,
         getContentSteering,
         getDuration,
+        getEssentialPropertiesForAdaptationSet,
         getEssentialPropertiesForRepresentation,
         getEvent,
         getEventsFor,

src/dash/DashAdapter.js

@@ -128,7 +128,8 @@ function SegmentBaseLoader() {
             searching: false,
             bytesLoaded: 0,
             bytesToLoad: 1500,
-            mediaType: mediaType
+            mediaType: mediaType,
+            representation
         };
 
         logger.debug('Start searching for initialization.');
@@ -183,7 +184,8 @@ function SegmentBaseLoader() {
             searching: !hasRange,
             bytesLoaded: loadingInfo ? loadingInfo.bytesLoaded : 0,
             bytesToLoad: 1500,
-            mediaType: mediaType
+            mediaType: mediaType,
+            representation
         };
 
         const request = getFragmentRequest(info);