Remove unused request.quality (Dash-Industry-Forum#4726)

Author: dsilhavy

src/streaming/controllers/BufferController.js

@@ -305,7 +305,7 @@ function BufferController(config) {
             logger.info('Init fragment finished loading saving to', type + '\'s init cache');
             initCache.save(e.chunk);
         }
-        logger.debug('Append Init fragment', type, ' with representationId:', e.chunk.representation.id, ' and quality:', e.chunk.quality, ', data size:', e.chunk.bytes.byteLength);
+        logger.debug(`Appending init fragment for type ${type}, representationId ${e.chunk.representation.id} and bandwidth ${e.chunk.representation.bandwidth}`);
         _appendToBuffer(e.chunk);
     }
 
@@ -324,7 +324,8 @@ function BufferController(config) {
         }
 
         // Append init segment into buffer
-        logger.info('Append Init fragment', type, ' with representationId:', chunk.representation.id, ' and quality:', chunk.quality, ', data size:', chunk.bytes.byteLength);
+        logger.debug(`Appending init fragment for type ${type}, representationId ${chunk.representation.id} and bandwidth ${chunk.representation.bandwidth}`);
+
         _appendToBuffer(chunk);
 
         return true;

src/streaming/controllers/FragmentController.js

@@ -120,7 +120,6 @@ function FragmentController(config) {
         chunk.end = chunk.start + chunk.duration;
         chunk.bytes = bytes;
         chunk.index = request.index;
-        chunk.quality = request.quality;
         chunk.representation = request.representation;
         chunk.endFragment = endFragment;
 

src/streaming/models/FragmentModel.js

@@ -129,8 +129,7 @@ function FragmentModel(config) {
      * @param {Object} filter The object with properties by which the method filters the requests to be returned.
      *  the only mandatory property is state, which must be a value from
      *  other properties should match the properties of {@link FragmentRequest}. E.g.:
-     *  getRequests({state: FragmentModel.FRAGMENT_MODEL_EXECUTED, quality: 0}) - returns
-     *  all the requests from executedRequests array where requests.quality = filter.quality
+     *  getRequests({state: FragmentModel.FRAGMENT_MODEL_EXECUTED, quality: 0})
      *
      * @returns {Array}
      * @memberof FragmentModel#

src/streaming/models/MetricsModel.js

@@ -153,7 +153,6 @@ function MetricsModel(config) {
                 mediaType: request.mediaType,
                 type: request.type,
                 url: request.url,
-                quality: request.quality,
                 serviceLocation: null,
                 range: request.range,
                 startDate: request.startDate,
@@ -187,7 +186,6 @@ function MetricsModel(config) {
         vo._tfinish = request.endDate;
         vo._stream = request.mediaType;
         vo._mediaduration = request.duration;
-        vo._quality = request.quality;
         // For backward compatibility, convert response headers into string representation
         vo._responseHeaders = '';
         for (const key in response.headers) {

src/streaming/vo/DataChunk.js

@@ -38,7 +38,6 @@ class DataChunk {
     constructor() {
         this.streamId = null;
         this.segmentType = null;
-        this.quality = NaN;
         this.index = NaN;
         this.bytes = null;
         this.start = NaN;

src/streaming/vo/FragmentRequest.js

@@ -50,7 +50,6 @@ class FragmentRequest {
         this.index = NaN;
         this.mediaStartTime = NaN;
         this.mediaType = null;
-        this.quality = NaN;
         this.range = null;
         this.representation = null;
         this.responseType = 'arraybuffer';

src/streaming/vo/metrics/HTTPRequest.js

@@ -118,11 +118,6 @@ class HTTPRequest {
          * @public
          */
         this._mediaduration = null;
-        /**
-         * The media segment quality
-         * @public
-         */
-        this._quality = null;
         /**
          * all the response headers from request.
          * @public