Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Commit df65b08

Browse files
authored
Can delete (#23)
* add get_input_device_by_id method and delete useless template * fix avaliability problem * add describe_event function and delete real password and username * fix 'event_can_delete' * fix * fix
1 parent ebc266c commit df65b08

File tree

2 files changed

+7
-21
lines changed

2 files changed

+7
-21
lines changed

elemental/client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,5 @@ def event_can_delete(self, channel_id):
235235
channel_info = self.describe_event(channel_id)
236236
if channel_info['status'] in ('pending', 'running',
237237
'preprocessing', 'postprocessing'):
238-
return {'deletable': False}
239-
else:
240-
return {'deletable': True}
238+
raise ElementalException(
239+
f"Channel: {channel_id} is not deletable")

elemental/client_test.py

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ def test_describe_event_will_return_event_info_as_expect():
426426
'status': 'complete'}
427427

428428

429-
def test_event_can_delete_will_return_False_if_pending():
429+
def test_event_can_delete_will_raise_exception_if_pending():
430430
client = ElementalLive(ELEMENTAL_ADDRESS, USER, API_KEY)
431431

432432
client.describe_event = mock.Mock()
@@ -435,22 +435,9 @@ def test_event_can_delete_will_return_False_if_pending():
435435
'origin_url': 'fake_origin',
436436
'backup_url': 'fake_backup'
437437
}
438-
d = client.event_can_delete('123')
439-
assert d == {
440-
'deletable': False
441-
}
442-
443438

444-
def test_event_can_delete_will_return_True_if_complete():
445-
client = ElementalLive(ELEMENTAL_ADDRESS, USER, API_KEY)
439+
with pytest.raises(ElementalException) as exc_info:
440+
client.event_can_delete('123')
446441

447-
client.describe_event = mock.Mock()
448-
client.describe_event.return_value = {
449-
'status': 'complete',
450-
'origin_url': 'fake_origin',
451-
'backup_url': 'fake_backup'
452-
}
453-
d = client.event_can_delete('321')
454-
assert d == {
455-
'deletable': True
456-
}
442+
assert str(exc_info.value).endswith(
443+
f"Channel: 123 is not deletable")

0 commit comments

Comments
 (0)