Handle EME key status errors such as "internal-error" and "output-restricted" before appending media (video-dev#7414)

* Handle EME key status errors before appending segments
Fixes video-dev#7413 (playback/switching fails on KEY_SYSTEM_STATUS_INTERNAL_ERROR 'internal-error' key status)

* Fix handling of one-to-many KEY URI to Key IDs
video-dev#7413

* Remove levels with "internal-error" key status errors and optimize key-bytes comparison
Add "FIXME" comments for future MediaKeySessionContext multi-key handling improvements

* Do not throw fatal keyLoadingPromise error when context changes on KEY_LOADING
reproducible with `hls.once(Hls.Events.KEY_LOADING, () => hls.removeLevel(hls.loadLevel))`

Author: robwalch

api-extractor/report/hls.js.api.md

@@ -1189,8 +1189,8 @@ export type EMEControllerConfig = {
     licenseResponseCallback?: (this: Hls, xhr: XMLHttpRequest, url: string, keyContext: MediaKeySessionContext) => ArrayBuffer;
     emeEnabled: boolean;
     widevineLicenseUrl?: string;
-    drmSystems: DRMSystemsConfiguration;
-    drmSystemOptions: DRMSystemOptions;
+    drmSystems: DRMSystemsConfiguration | undefined;
+    drmSystemOptions: DRMSystemOptions | undefined;
     requestMediaKeySystemAccessFunc: MediaKeyFunc | null;
     requireKeySystemAccessOnStart: boolean;
 };
@@ -1204,9 +1204,11 @@ export const enum ErrorActionFlags {
     // (undocumented)
     MoveAllAlternatesMatchingHost = 1,
     // (undocumented)
+    MoveAllAlternatesMatchingKey = 4,
+    // (undocumented)
     None = 0,
     // (undocumented)
-    SwitchToSDR = 4
+    SwitchToSDR = 8
 }
 
 // Warning: (ae-missing-release-tag) "ErrorController" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal)
@@ -1239,6 +1241,8 @@ export interface ErrorData {
     // (undocumented)
     context?: PlaylistLoaderContext;
     // (undocumented)
+    decryptdata?: LevelKey;
+    // (undocumented)
     details: ErrorDetails;
     // @deprecated (undocumented)
     err?: {
@@ -2981,8 +2985,8 @@ export interface KeyLoadedData {
 // Warning: (ae-missing-release-tag) "KeyLoader" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public (undocumented)
-export class KeyLoader implements ComponentAPI {
-    constructor(config: HlsConfig);
+export class KeyLoader extends Logger implements ComponentAPI {
+    constructor(config: HlsConfig, logger: ILogger);
     // (undocumented)
     abort(type?: PlaylistLevelType): void;
     // (undocumented)
@@ -2999,10 +3003,6 @@ export class KeyLoader implements ComponentAPI {
     // (undocumented)
     emeController: EMEController | null;
     // (undocumented)
-    keyUriToKeyInfo: {
-        [keyuri: string]: KeyLoaderInfo;
-    };
-    // (undocumented)
     load(frag: Fragment): Promise<KeyLoadedData>;
     // (undocumented)
     loadClear(loadingFrag: Fragment, encryptedFragments: Fragment[], startFragRequested: boolean): null | Promise<void>;
@@ -3278,6 +3278,8 @@ export class LevelDetails {
     // (undocumented)
     get fragmentStart(): number;
     // (undocumented)
+    hasKey(levelKey: LevelKey): boolean;
+    // (undocumented)
     get hasProgramDateTime(): boolean;
     // (undocumented)
     hasVariableRefs: boolean;

src/config.ts

@@ -119,8 +119,8 @@ export type EMEControllerConfig = {
   ) => ArrayBuffer;
   emeEnabled: boolean;
   widevineLicenseUrl?: string;
-  drmSystems: DRMSystemsConfiguration;
-  drmSystemOptions: DRMSystemOptions;
+  drmSystems: DRMSystemsConfiguration | undefined;
+  drmSystemOptions: DRMSystemOptions | undefined;
   requestMediaKeySystemAccessFunc: MediaKeyFunc | null;
   requireKeySystemAccessOnStart: boolean;
 };

src/controller/base-stream-controller.ts

@@ -841,10 +841,9 @@ export default class BaseStreamController
         }
       });
       this.hls.trigger(Events.KEY_LOADING, { frag });
-      if (this.fragCurrent === null) {
-        keyLoadingPromise = Promise.reject(
-          new Error(`frag load aborted, context changed in KEY_LOADING`),
-        );
+      if ((this.fragCurrent as Fragment | null) === null) {
+        this.log(`context changed in KEY_LOADING`);
+        return Promise.resolve(null);
       }
     } else if (!frag.encrypted) {
       keyLoadingPromise = this.keyLoader.loadClear(
@@ -1040,11 +1039,16 @@ export default class BaseStreamController
     );
   }
 
-  private handleFragLoadError(error: LoadError | Error) {
+  private handleFragLoadError(
+    error: LoadError | Error | (Error & { data: ErrorData }),
+  ) {
     if ('data' in error) {
       const data = error.data;
-      if ((data as any) && data.details === ErrorDetails.INTERNAL_ABORTED) {
+      if (data.frag && data.details === ErrorDetails.INTERNAL_ABORTED) {
         this.handleFragLoadAborted(data.frag, data.part);
+      } else if (data.frag && data.type === ErrorTypes.KEY_SYSTEM_ERROR) {
+        data.frag.abortRequests();
+        this.resetFragmentLoading(data.frag);
       } else {
         this.hls.trigger(Events.ERROR, data as ErrorData);
       }
@@ -1826,7 +1830,7 @@ export default class BaseStreamController
     return pos;
   }
 
-  private handleFragLoadAborted(frag: Fragment, part: Part | undefined) {
+  private handleFragLoadAborted(frag: Fragment, part: Part | null | undefined) {
     if (
       this.transmuxer &&
       frag.type === this.playlistType &&
@@ -2033,8 +2037,8 @@ export default class BaseStreamController
   }
 
   protected resetWhenMissingContext(chunkMeta: ChunkMetadata | Fragment) {
-    this.warn(
-      `The loading context changed while buffering fragment ${chunkMeta.sn} of ${this.playlistLabel()} ${chunkMeta.level}. This chunk will not be buffered.`,
+    this.log(
+      `Loading context changed while buffering sn ${chunkMeta.sn} of ${this.playlistLabel()} ${chunkMeta.level === -1 ? '<removed>' : chunkMeta.level}. This chunk will not be buffered.`,
     );
     this.removeUnbufferedFrags();
     this.resetStartWhenNotLoaded(this.levelLastLoaded);