Refactor health endpoint tests to use more readable style (elastic#112433)

This changes the mutate object method in 3 health endpoint related tests to use a lambda switch and local
variable pattern that's more compact and understandable

This is the promised follow up to elastic#112024

Author: lukewhiting

server/src/test/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthResponsesTests.java

@@ -263,103 +263,46 @@ protected Predicate<String> getRandomFieldsExcludeFilter() {
 
     @Override
     protected ClusterHealthResponse mutateInstance(ClusterHealthResponse instance) {
-        String mutate = randomFrom(
-            "clusterName",
-            "numberOfPendingTasks",
-            "numberOfInFlightFetch",
-            "delayedUnassignedShards",
-            "taskMaxWaitingTime",
-            "timedOut",
-            "clusterStateHealth"
-        );
-        switch (mutate) {
-            case "clusterName":
-                return new ClusterHealthResponse(
-                    instance.getClusterName() + randomAlphaOfLengthBetween(2, 5),
-                    instance.getNumberOfPendingTasks(),
-                    instance.getNumberOfInFlightFetch(),
-                    instance.getDelayedUnassignedShards(),
-                    instance.getTaskMaxWaitingTime(),
-                    instance.isTimedOut(),
-                    instance.getClusterStateHealth()
-                );
-            case "numberOfPendingTasks":
-                return new ClusterHealthResponse(
-                    instance.getClusterName(),
-                    instance.getNumberOfPendingTasks() + between(1, 10),
-                    instance.getNumberOfInFlightFetch(),
-                    instance.getDelayedUnassignedShards(),
-                    instance.getTaskMaxWaitingTime(),
-                    instance.isTimedOut(),
-                    instance.getClusterStateHealth()
-                );
-            case "numberOfInFlightFetch":
-                return new ClusterHealthResponse(
-                    instance.getClusterName(),
-                    instance.getNumberOfPendingTasks(),
-                    instance.getNumberOfInFlightFetch() + between(1, 10),
-                    instance.getDelayedUnassignedShards(),
-                    instance.getTaskMaxWaitingTime(),
-                    instance.isTimedOut(),
-                    instance.getClusterStateHealth()
-                );
-            case "delayedUnassignedShards":
-                return new ClusterHealthResponse(
-                    instance.getClusterName(),
-                    instance.getNumberOfPendingTasks(),
-                    instance.getNumberOfInFlightFetch(),
-                    instance.getDelayedUnassignedShards() + between(1, 10),
-                    instance.getTaskMaxWaitingTime(),
-                    instance.isTimedOut(),
-                    instance.getClusterStateHealth()
-                );
-            case "taskMaxWaitingTime":
+        String clusterName = instance.getClusterName();
+        int numberOfPendingTasks = instance.getNumberOfPendingTasks();
+        int numberOfInFlightFetch = instance.getNumberOfInFlightFetch();
+        int delayedUnassignedShards = instance.getDelayedUnassignedShards();
+        TimeValue taskMaxWaitingTime = instance.getTaskMaxWaitingTime();
+        boolean timedOut = instance.isTimedOut();
+        ClusterStateHealth clusterStateHealth = instance.getClusterStateHealth();
 
-                return new ClusterHealthResponse(
-                    instance.getClusterName(),
-                    instance.getNumberOfPendingTasks(),
-                    instance.getNumberOfInFlightFetch(),
-                    instance.getDelayedUnassignedShards(),
-                    new TimeValue(instance.getTaskMaxWaitingTime().millis() + between(1, 10)),
-                    instance.isTimedOut(),
-                    instance.getClusterStateHealth()
-                );
-            case "timedOut":
-                return new ClusterHealthResponse(
-                    instance.getClusterName(),
-                    instance.getNumberOfPendingTasks(),
-                    instance.getNumberOfInFlightFetch(),
-                    instance.getDelayedUnassignedShards(),
-                    instance.getTaskMaxWaitingTime(),
-                    instance.isTimedOut() ? false : true,
-                    instance.getClusterStateHealth()
-                );
-            case "clusterStateHealth":
-                ClusterStateHealth state = instance.getClusterStateHealth();
-                ClusterStateHealth newState = new ClusterStateHealth(
-                    state.getActivePrimaryShards() + between(1, 10),
-                    state.getActiveShards(),
-                    state.getRelocatingShards(),
-                    state.getInitializingShards(),
-                    state.getUnassignedShards(),
-                    state.getUnassignedPrimaryShards(),
-                    state.getNumberOfNodes(),
-                    state.getNumberOfDataNodes(),
-                    state.getActiveShardsPercent(),
-                    state.getStatus(),
-                    state.getIndices()
-                );
-                return new ClusterHealthResponse(
-                    instance.getClusterName(),
-                    instance.getNumberOfPendingTasks(),
-                    instance.getNumberOfInFlightFetch(),
-                    instance.getDelayedUnassignedShards(),
-                    instance.getTaskMaxWaitingTime(),
-                    instance.isTimedOut(),
-                    newState
-                );
-            default:
-                throw new UnsupportedOperationException();
+        switch (randomIntBetween(0, 6)) {
+            case 0 -> clusterName += randomAlphaOfLengthBetween(2, 5);
+            case 1 -> numberOfPendingTasks += between(1, 10);
+            case 2 -> numberOfInFlightFetch += between(1, 10);
+            case 3 -> delayedUnassignedShards += between(1, 10);
+            case 4 -> taskMaxWaitingTime = new TimeValue(instance.getTaskMaxWaitingTime().millis() + between(1, 10));
+            case 5 -> timedOut = timedOut ? false : true;
+            case 6 -> clusterStateHealth = new ClusterStateHealth(
+                clusterStateHealth.getActivePrimaryShards() + between(1, 10),
+                clusterStateHealth.getActiveShards(),
+                clusterStateHealth.getRelocatingShards(),
+                clusterStateHealth.getInitializingShards(),
+                clusterStateHealth.getUnassignedShards(),
+                clusterStateHealth.getUnassignedPrimaryShards(),
+                clusterStateHealth.getNumberOfNodes(),
+                clusterStateHealth.getNumberOfDataNodes(),
+                clusterStateHealth.getActiveShardsPercent(),
+                clusterStateHealth.getStatus(),
+                clusterStateHealth.getIndices()
+            );
+            default -> throw new UnsupportedOperationException();
         }
+
+        return new ClusterHealthResponse(
+            clusterName,
+            numberOfPendingTasks,
+            numberOfInFlightFetch,
+            delayedUnassignedShards,
+            taskMaxWaitingTime,
+            timedOut,
+            clusterStateHealth
+        );
     }
+
 }

server/src/test/java/org/elasticsearch/cluster/health/ClusterIndexHealthTests.java

@@ -22,7 +22,6 @@
 import org.elasticsearch.xcontent.XContentParser;
 
 import java.io.IOException;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
@@ -141,187 +140,52 @@ protected Predicate<String> getRandomFieldsExcludeFilter() {
 
     @Override
     protected ClusterIndexHealth mutateInstance(ClusterIndexHealth instance) {
-        String mutate = randomFrom(
-            "index",
-            "numberOfShards",
-            "numberOfReplicas",
-            "activeShards",
-            "relocatingShards",
-            "initializingShards",
-            "unassignedShards",
-            "unassignedPrimaryShards",
-            "activePrimaryShards",
-            "status",
-            "shards"
-        );
-        switch (mutate) {
-            case "index":
-                return new ClusterIndexHealth(
-                    instance.getIndex() + randomAlphaOfLengthBetween(2, 5),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "numberOfShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards() + between(1, 10),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "numberOfReplicas":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas() + between(1, 10),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "activeShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards() + between(1, 10),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "relocatingShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards() + between(1, 10),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "initializingShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards() + between(1, 10),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "unassignedShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards() + between(1, 10),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "unassignedPrimaryShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards() + between(1, 10),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "activePrimaryShards":
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards() + between(1, 10),
-                    instance.getStatus(),
-                    instance.getShards()
-                );
-            case "status":
-                ClusterHealthStatus status = randomFrom(
-                    Arrays.stream(ClusterHealthStatus.values()).filter(value -> value.equals(instance.getStatus()) == false).toList()
-                );
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    status,
-                    instance.getShards()
-                );
-            case "shards":
-                Map<Integer, ClusterShardHealth> map;
+        String index = instance.getIndex();
+        int numberOfShards = instance.getNumberOfShards();
+        int numberOfReplicas = instance.getNumberOfReplicas();
+        int activeShards = instance.getActiveShards();
+        int relocatingShards = instance.getRelocatingShards();
+        int initializingShards = instance.getInitializingShards();
+        int unassignedShards = instance.getUnassignedShards();
+        int unassignedPrimaryShards = instance.getUnassignedPrimaryShards();
+        int activePrimaryShards = instance.getActivePrimaryShards();
+        ClusterHealthStatus status = instance.getStatus();
+        Map<Integer, ClusterShardHealth> shards = new HashMap<>(instance.getShards());
+
+        switch (randomIntBetween(0, 10)) {
+            case 0 -> index += randomAlphaOfLengthBetween(2, 5);
+            case 1 -> numberOfShards += between(1, 10);
+            case 2 -> numberOfReplicas += between(1, 10);
+            case 3 -> activeShards += between(1, 10);
+            case 4 -> relocatingShards += between(1, 10);
+            case 5 -> initializingShards += between(1, 10);
+            case 6 -> unassignedShards += between(1, 10);
+            case 7 -> unassignedPrimaryShards += between(1, 10);
+            case 8 -> activePrimaryShards += between(1, 10);
+            case 9 -> status = randomValueOtherThan(instance.getStatus(), () -> randomFrom(ClusterHealthStatus.values()));
+            case 10 -> {
                 if (instance.getShards().isEmpty()) {
-                    map = Collections.singletonMap(0, ClusterShardHealthTests.randomShardHealth(0));
+                    shards = Map.of(0, ClusterShardHealthTests.randomShardHealth(0));
                 } else {
-                    map = new HashMap<>(instance.getShards());
-                    map.remove(map.keySet().iterator().next());
+                    shards.remove(shards.keySet().iterator().next());
                 }
-                return new ClusterIndexHealth(
-                    instance.getIndex(),
-                    instance.getNumberOfShards(),
-                    instance.getNumberOfReplicas(),
-                    instance.getActiveShards(),
-                    instance.getRelocatingShards(),
-                    instance.getInitializingShards(),
-                    instance.getUnassignedShards(),
-                    instance.getUnassignedPrimaryShards(),
-                    instance.getActivePrimaryShards(),
-                    instance.getStatus(),
-                    map
-                );
-            default:
-                throw new UnsupportedOperationException();
+            }
+            default -> throw new UnsupportedOperationException();
         }
+
+        return new ClusterIndexHealth(
+            index,
+            numberOfShards,
+            numberOfReplicas,
+            activeShards,
+            relocatingShards,
+            initializingShards,
+            unassignedShards,
+            unassignedPrimaryShards,
+            activePrimaryShards,
+            status,
+            shards
+        );
     }
 
     private static final ConstructingObjectParser<ClusterIndexHealth, String> PARSER = new ConstructingObjectParser<>(