Fix HMAC self-tests

zlukwins · jyao1 · commit 9576455746d6 · 2025-05-21T22:26:57.000+08:00
Signed-off-by: Zbigniew Lukwinski &lt;zbigniew.lukwinski@intel.com&gt;
diff --git a/spdmlib/src/crypto/fips/hmac_st/mod.rs b/spdmlib/src/crypto/fips/hmac_st/mod.rs
@@ -31,7 +31,6 @@ pub fn run_self_tests() -> SpdmResult {
             mac.data.copy_from_slice(&vecc);
 
             if hmac::hmac_verify(SpdmBaseHashAlgo::TPM_ALG_SHA_256, cv.key, cv.msg, &mac).is_err() {
-                assert!(false, "Failed to run verify");
                 return Err(SPDM_STATUS_FIPS_SELF_TEST_FAIL);
             }
         }
@@ -51,7 +50,6 @@ pub fn run_self_tests() -> SpdmResult {
             mac.data.copy_from_slice(&vecc);
 
             if hmac::hmac_verify(SpdmBaseHashAlgo::TPM_ALG_SHA_384, cv.key, cv.msg, &mac).is_err() {
-                assert!(false, "Failed to run verify");
                 return Err(SPDM_STATUS_FIPS_SELF_TEST_FAIL);
             }
         }
@@ -71,7 +69,6 @@ pub fn run_self_tests() -> SpdmResult {
             mac.data.copy_from_slice(&vecc);
 
             if hmac::hmac_verify(SpdmBaseHashAlgo::TPM_ALG_SHA_512, cv.key, cv.msg, &mac).is_err() {
-                assert!(false, "Failed to run verify");
                 return Err(SPDM_STATUS_FIPS_SELF_TEST_FAIL);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ pub fn run_self_tests() -> SpdmResult {`
`31`	`31`	`mac.data.copy_from_slice(&vecc);`
`32`	`32`
`33`	`33`	`if hmac::hmac_verify(SpdmBaseHashAlgo::TPM_ALG_SHA_256, cv.key, cv.msg, &mac).is_err() {`
`34`		`- assert!(false, "Failed to run verify");`
`35`	`34`	`return Err(SPDM_STATUS_FIPS_SELF_TEST_FAIL);`
`36`	`35`	`}`
`37`	`36`	`}`
`@@ -51,7 +50,6 @@ pub fn run_self_tests() -> SpdmResult {`
`51`	`50`	`mac.data.copy_from_slice(&vecc);`
`52`	`51`
`53`	`52`	`if hmac::hmac_verify(SpdmBaseHashAlgo::TPM_ALG_SHA_384, cv.key, cv.msg, &mac).is_err() {`
`54`		`- assert!(false, "Failed to run verify");`
`55`	`53`	`return Err(SPDM_STATUS_FIPS_SELF_TEST_FAIL);`
`56`	`54`	`}`
`57`	`55`	`}`
`@@ -71,7 +69,6 @@ pub fn run_self_tests() -> SpdmResult {`
`71`	`69`	`mac.data.copy_from_slice(&vecc);`
`72`	`70`
`73`	`71`	`if hmac::hmac_verify(SpdmBaseHashAlgo::TPM_ALG_SHA_512, cv.key, cv.msg, &mac).is_err() {`
`74`		`- assert!(false, "Failed to run verify");`
`75`	`72`	`return Err(SPDM_STATUS_FIPS_SELF_TEST_FAIL);`
`76`	`73`	`}`
`77`	`74`	`}`