Skip to content

Commit a4c2590

Browse files
authored
Fixed Iterable import and SHELX testing threshold (#73)
1 parent b71c305 commit a4c2590

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
- Avoid re-importing files with the same checksum
66
- Fix for the Coot RSR Morph task on Windows
7+
- Fixed collections.Iterable import
8+
- Changed some performance testing thresholds
79

810
## [2.3.1] - 2025-05-17
911

pipelines/crank2/crank2/program.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import with_statement
22
import os,sys,copy,re
3+
from collections.abc import Iterable
34
from xml.etree import ElementTree as ET
45
import subprocess,threading,time
56
from distutils import spawn
@@ -437,8 +438,7 @@ def GetStatGrep(self, stat, param=[], from_str=None, param_escape=True, multiple
437438
f = open(logfile,"r")
438439
from_str = f.read()
439440
if param:
440-
import collections
441-
if common.is_string(param) or not isinstance(param, collections.Iterable):
441+
if common.is_string(param) or not isinstance(param, Iterable):
442442
param = [param,]
443443
if param_escape:
444444
param = [re.escape(str(p)) for p in param]

test/i2run/test_shelx.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def test_gamma_sad():
1919
with i2run(args) as job:
2020
read_pdb(str(job / "n_part.pdb"))
2121
read_pdb(str(job / "n_PDBCUR.pdb"))
22-
_check_output(job, min_fom=0.7, max_rwork=0.21, max_rfree=0.25)
22+
_check_output(job, min_fom=0.7, max_rwork=0.22, max_rfree=0.25)
2323

2424

2525
def test_gamma_siras():

0 commit comments

Comments
 (0)