Skip to content

Latest DECTRIS EIGER file writer breaks DIALS (again) #865

@graeme-winter

Description

@graeme-winter

Good news! Another chance to fix dxtbx file handling to adapt to the latest output from our friends in Baden

ethics-gradient:tmp graeme$ dials.import DAPK_5a.001_master.h5 
DIALS (2018) Acta Cryst. D74, 85-97. https://doi.org/10.1107/S2059798317017235
DIALS 3.dev.1392-g1e3e97fa7
Traceback (most recent call last):
  File "/Users/graeme/git/dials/conda_base/bin/dials.import", line 8, in <module>
    sys.exit(run())
             ^^^^^
  File "/Users/graeme/git/dials/conda_base/lib/python3.12/contextlib.py", line 81, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dials/src/dials/command_line/dials_import.py", line 1013, in run
    do_import(args, phil=phil, configure_logging=True)
  File "/Users/graeme/git/dials/modules/dials/src/dials/command_line/dials_import.py", line 858, in do_import
    params, options, unhandled = parser.parse_args(
                                 ^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dials/src/dials/util/options.py", line 876, in parse_args
    params, args = self._phil_parser.parse_args(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dials/src/dials/util/options.py", line 558, in parse_args
    importer = Importer(
               ^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dials/src/dials/util/options.py", line 207, in __init__
    self.unhandled = self.try_read_experiments_from_images(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dials/src/dials/util/options.py", line 284, in try_read_experiments_from_images
    experiments = ExperimentListFactory.from_filenames(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/model/experiment_list.py", line 709, in from_filenames
    imageset = format_class.get_imageset(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/FormatMultiImage.py", line 161, in get_imageset
    format_instance = cls.get_instance(filenames[0], **format_kwargs)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/Format.py", line 275, in get_instance
    Class._current_instance_ = Class(filename, **kwargs)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/FormatNXmxEigerFilewriter.py", line 54, in __init__
    super().__init__(image_file, **kwargs)
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/FormatNXmx.py", line 88, in __init__
    super().__init__(image_file, **kwargs)
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/FormatHDF5.py", line 16, in __init__
    Format.__init__(self, image_file, **kwargs)
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/Format.py", line 169, in __init__
    self.setup()
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/Format.py", line 179, in setup
    self._start()
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/FormatNXmxEigerFilewriter.py", line 57, in _start
    super()._start()
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/format/FormatNXmx.py", line 104, in _start
    self._detector_model = dxtbx.nexus.get_dxtbx_detector(
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/graeme/git/dials/modules/dxtbx/src/dxtbx/nexus/__init__.py", line 360, in get_dxtbx_detector
    assert module.fast_pixel_direction.depends_on is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Please report this error at https://github.com/dials/dials/issues or to [email protected]:

Two independent reports, one from LS-CAT here at the APS and another from a user from CHESS

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions