Skip to content

Commit 7962e64

Browse files
authored
fix(client): upgrade allTickers to miniTicker, stream was deprecated (#687)
* fix(client): upgrade allTickers to miniTicker because stream was deprecated * rm comment * update test * update tests * missing file
1 parent ee6addd commit 7962e64

File tree

3 files changed

+32
-4
lines changed

3 files changed

+32
-4
lines changed

src/websocket.js

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,33 @@ const ticker = (payload, cb, transform = true, variator) => {
378378
}
379379

380380
const allTickers = (cb, transform = true, variator) => {
381+
const w = new openWebSocket(
382+
`${
383+
variator === 'futures'
384+
? endpoints.futures
385+
: variator === 'delivery'
386+
? endpoints.delivery
387+
: endpoints.base
388+
}/!miniTicker@arr`,
389+
)
390+
391+
w.onmessage = msg => {
392+
const arr = JSONbig.parse(msg.data)
393+
cb(
394+
transform
395+
? variator === 'futures'
396+
? arr.map(m => futuresTickerTransform(m))
397+
: variator === 'delivery'
398+
? arr.map(m => deliveryTickerTransform(m))
399+
: arr.map(m => tickerTransform(m))
400+
: arr,
401+
)
402+
}
403+
404+
return options => w.close(1000, 'Close handle was called', { keepClosed: true, ...options })
405+
}
406+
407+
const allTickersDeprecated = (cb, transform = true, variator) => {
381408
const w = new openWebSocket(
382409
`${
383410
variator === 'futures'
@@ -980,6 +1007,7 @@ export default opts => {
9801007
bookTicker,
9811008
ticker,
9821009
allTickers,
1010+
allTickersDeprecated,
9831011
miniTicker,
9841012
allMiniTickers,
9851013
customSubStream,

test/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,8 @@ test('[WS] allTicker', t => {
250250
return new Promise(resolve => {
251251
client.ws.allTickers(tickers => {
252252
t.truthy(Array.isArray(tickers))
253-
t.is(tickers[0].eventType, '24hrTicker')
254-
checkFields(t, tickers[0], ['symbol', 'priceChange', 'priceChangePercent'])
253+
t.is(tickers[0].eventType, '24hrMiniTicker')
254+
checkFields(t, tickers[0], ['symbol', 'open', 'volume'])
255255
resolve()
256256
})
257257
})

test/websockets/ticker.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ test('[WS] allTickers', t => {
135135
return new Promise(resolve => {
136136
const clean = client.ws.allTickers(tickers => {
137137
t.truthy(Array.isArray(tickers))
138-
t.is(tickers[0].eventType, '24hrTicker')
139-
checkFields(t, tickers[0], ['symbol', 'priceChange', 'priceChangePercent'])
138+
t.is(tickers[0].eventType, '24hrMiniTicker')
139+
checkFields(t, tickers[0], ['symbol', 'open', 'volume'])
140140
clean()
141141
resolve()
142142
})

0 commit comments

Comments
 (0)