Merge pull request #794 from boyi/fix/origClientOrderIdList-string-format

carlosmiei · web-flow · commit 2842c6c146e9 · 2026-01-21T09:52:39.000-05:00
FIX: origClientOrderIdList format in BatchCancelOrders API
diff --git a/v2/futures/order_service.go b/v2/futures/order_service.go
@@ -791,7 +791,9 @@ func (s *CancelMultiplesOrdersService) Do(ctx context.Context, opts ...RequestOp
 		r.setFormParam("orderIdList", orderIDListString)
 	}
 	if s.origClientOrderIDList != nil {
-		r.setFormParam("origClientOrderIdList", s.origClientOrderIDList)
+		// convert a slice of strings to a string e.g. ["my_id_1","my_id_2"], encode the double quotes. No space after comma.
+		origClientOrderIDListString := "[\"" + strings.Join(s.origClientOrderIDList, "\",\"") + "\"]"
+		r.setFormParam("origClientOrderIdList", origClientOrderIDListString)
 	}
 	data, _, err := s.c.callAPI(ctx, r, opts...)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -791,7 +791,9 @@ func (s *CancelMultiplesOrdersService) Do(ctx context.Context, opts ...RequestOp`
`791`	`791`	`r.setFormParam("orderIdList", orderIDListString)`
`792`	`792`	`}`
`793`	`793`	`if s.origClientOrderIDList != nil {`
`794`		`- r.setFormParam("origClientOrderIdList", s.origClientOrderIDList)`
	`794`	`+ // convert a slice of strings to a string e.g. ["my_id_1","my_id_2"], encode the double quotes. No space after comma.`
	`795`	`+ origClientOrderIDListString := "[\"" + strings.Join(s.origClientOrderIDList, "\",\"") + "\"]"`
	`796`	`+ r.setFormParam("origClientOrderIdList", origClientOrderIDListString)`
`795`	`797`	`}`
`796`	`798`	`data, _, err := s.c.callAPI(ctx, r, opts...)`
`797`	`799`	`if err != nil {`