Skip to content

Commit 43e04c8

Browse files
authored
Merge pull request #521 from yzh-pelle/fix-nullable
fix: nullable types added to signatures
2 parents 5539e0a + 84b9dda commit 43e04c8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

php-binance-api.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ public function cancelOpenOrders(string $symbol, array $params = [])
607607
* @return array with error message or array of orderDetails array
608608
* @throws \Exception
609609
*/
610-
public function orders(string $symbol, ?int $limit = null, int $fromOrderId = null, array $params = [])
610+
public function orders(string $symbol, ?int $limit = null, ?int $fromOrderId = null, array $params = [])
611611
{
612612
$request = [
613613
"symbol" => $symbol,
@@ -1316,7 +1316,7 @@ public function tradingDay(?string $symbol = null, ?array $symbols = null, array
13161316
* @return array with error message or array of prevDay change
13171317
* @throws \Exception
13181318
*/
1319-
public function rollingWindowPriceChange(?string $symbol = null, array $symbols = null, string $windowSize = null, array $params = [])
1319+
public function rollingWindowPriceChange(?string $symbol = null, ?array $symbols = null, ?string $windowSize = null, array $params = [])
13201320
{
13211321
$request = [];
13221322
if (!is_null($symbol) && is_string($symbol)) {
@@ -2058,7 +2058,7 @@ public function sorOrder(string $side, string $symbol, $quantity, $price, string
20582058
* returns array containing the response
20592059
* @throws \Exception
20602060
*/
2061-
public function replaceOrder(string $side, string $symbol, $quantity, $price, string $type = "LIMIT", ?string $cancelOrderId = null, string $cancelOrigClientOrderId = null, bool $allowFailure = null, string $cancelRestrictions = null, string $orderRateLimitExceededMode = null, array $params = [])
2061+
public function replaceOrder(string $side, string $symbol, $quantity, $price, string $type = "LIMIT", ?string $cancelOrderId = null, ?string $cancelOrigClientOrderId = null, ?bool $allowFailure = null, ?string $cancelRestrictions = null, ?string $orderRateLimitExceededMode = null, array $params = [])
20622062
{
20632063
$request = $this->createSpotOrderRequest($side, $symbol, $quantity, $price, $type, $params);
20642064
if (!is_null($cancelOrderId)) {

0 commit comments

Comments
 (0)