Pick correct file if two files with the same name but with different extensions exist (pylint-dev#2722) (pylint-dev#2728)

Co-authored-by: Charlie Ringström <[email protected]>

Author: Pierre-Sassoulas

ChangeLog

@@ -17,6 +17,11 @@ Release date: TBA
 
   Closes #2684
 
+* Fix bug where ``pylint code.custom_extension`` would analyze ``code.py`` or ``code.pyi`` instead if they existed.
+
+	Closes pylint-dev/pylint#3631
+
+
 What's New in astroid 3.3.9?
 ============================
 Release date: 2025-03-09

astroid/modutils.py

@@ -487,8 +487,9 @@ def get_source_file(
     """
     filename = os.path.abspath(_path_from_filename(filename))
     base, orig_ext = os.path.splitext(filename)
-    if orig_ext == ".pyi" and os.path.exists(f"{base}{orig_ext}"):
-        return f"{base}{orig_ext}"
+    orig_ext = orig_ext.lstrip(".")
+    if orig_ext not in PY_SOURCE_EXTS and os.path.exists(f"{base}.{orig_ext}"):
+        return f"{base}.{orig_ext}"
     for ext in PY_SOURCE_EXTS_STUBS_FIRST if prefer_stubs else PY_SOURCE_EXTS:
         source_path = f"{base}.{ext}"
         if os.path.exists(source_path):

script/.contributors_aliases.json

@@ -1,4 +1,8 @@
 {
+  "[email protected]": {
+    "mails": ["[email protected]"],
+    "name": "Charlie Ringström"
+  },
   "[email protected]": {
     "mails": ["[email protected]"],
     "name": "correctmost"

tests/test_modutils.py

@@ -304,6 +304,22 @@ def test_pyi_preferred(self) -> None:
             os.path.normpath(module) + "i",
         )
 
+    def test_nonstandard_extension(self) -> None:
+        package = resources.find("pyi_data/find_test")
+        modules = [
+            os.path.join(package, "__init__.weird_ext"),
+            os.path.join(package, "standalone_file.weird_ext"),
+        ]
+        for module in modules:
+            self.assertEqual(
+                modutils.get_source_file(module, prefer_stubs=True),
+                module,
+            )
+            self.assertEqual(
+                modutils.get_source_file(module),
+                module,
+            )
+
 
 class IsStandardModuleTest(resources.SysPathSetup, unittest.TestCase):
     """