Skip to content

Commit 1d8dc7f

Browse files
tarekbadrshafrittoli
authored andcommitted
add service obj
1 parent 6dbc8ac commit 1d8dc7f

File tree

8 files changed

+58
-57
lines changed

8 files changed

+58
-57
lines changed

cli/cdevents/cli/artifact.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
"""Module for cli artifact commands."""
22
from __future__ import annotations
3-
43
from typing import List
54
import click
65

cli/cdevents/cli/branch.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
"""Module for cli branch commands."""
22
from __future__ import annotations
3-
43
from typing import List
5-
64
import click
75

86
from cdevents.cli.utils import add_disclaimer_text, print_function_args

cli/cdevents/cli/build.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
"""Module for cli build commands."""
22
from __future__ import annotations
3-
4-
import os
53
from typing import List
6-
74
import click
85

96
from cdevents.cli.utils import add_disclaimer_text, print_function_args

cli/cdevents/cli/repository.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ def created(
5454
):
5555
print_function_args()
5656
repository = Repository(repository_type=RepositoryType.RepositoryCreatedEventV1, id=id, name=name, url=url)
57-
pipelinerun_event = repository.create_event(data)
57+
repository_event = repository.create_event(data)
5858
cdevents_command = CDeventsCommand()
59-
cdevents_command.run(pipelinerun_event)
59+
cdevents_command.run(repository_event)
6060

6161

6262
@click.command(help=add_disclaimer_text("Repository Modified CloudEvent."))
@@ -69,9 +69,9 @@ def modified(
6969
):
7070
print_function_args()
7171
repository = Repository(repository_type=RepositoryType.RepositoryModifiedEventV1, id=id, name=name, url=url)
72-
pipelinerun_event = repository.create_event(data)
72+
repository_event = repository.create_event(data)
7373
cdevents_command = CDeventsCommand()
74-
cdevents_command.run(pipelinerun_event)
74+
cdevents_command.run(repository_event)
7575

7676

7777
@click.command(help=add_disclaimer_text("Repository Deleted CloudEvent."))
@@ -84,7 +84,7 @@ def deleted(
8484
):
8585
print_function_args()
8686
repository = Repository(repository_type=RepositoryType.RepositoryDeletedEventV1, id=id, name=name, url=url)
87-
pipelinerun_event = repository.create_event(data)
87+
repository_event = repository.create_event(data)
8888
cdevents_command = CDeventsCommand()
89-
cdevents_command.run(pipelinerun_event)
89+
cdevents_command.run(repository_event)
9090

cli/cdevents/cli/service.py

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
"""Module for cli service commands."""
22
from __future__ import annotations
3-
4-
import os
53
from typing import List
6-
74
import click
85

96
from cdevents.cli.utils import add_disclaimer_text, print_function_args
107
from cdevents.cli.cdevents_command import CDeventsCommand
118

12-
from cdevents.core.events import Events
13-
from cdevents.core import event_type
9+
from cdevents.core.service import Service, ServiceType
1410

1511
# pylint: disable=unused-argument
1612
def common_service_options(function):
@@ -57,11 +53,10 @@ def deployed(
5753
data: List[str] = None,
5854
):
5955
print_function_args()
60-
e = Events()
61-
new_event = e.create_service_event(event_type.ServiceDeployedEventV1, envid, name, version, data)
56+
service = Service(service_type=ServiceType.ServiceDeployedEventV1, envid=envid, name=name, version=version)
57+
service_event = service.create_event(data)
6258
cdevents_command = CDeventsCommand()
63-
cdevents_command.run(new_event)
64-
59+
cdevents_command.run(service_event)
6560

6661
@click.command(help=add_disclaimer_text("Service Upgraded CloudEvent."))
6762
@common_service_options
@@ -72,10 +67,10 @@ def upgraded(
7267
data: List[str] = None,
7368
):
7469
print_function_args()
75-
e = Events()
76-
new_event = e.create_service_event(event_type.ServiceUpgradedEventV1, envid, name, version, data)
70+
service = Service(service_type=ServiceType.ServiceUpgradedEventV1, envid=envid, name=name, version=version)
71+
service_event = service.create_event(data)
7772
cdevents_command = CDeventsCommand()
78-
cdevents_command.run(new_event)
73+
cdevents_command.run(service_event)
7974

8075

8176
@click.command(help=add_disclaimer_text("Service Removed CloudEvent."))
@@ -87,10 +82,10 @@ def removed(
8782
data: List[str] = None,
8883
):
8984
print_function_args()
90-
e = Events()
91-
new_event = e.create_service_event(event_type.ServiceRemovedEventV1, envid, name, version, data)
85+
service = Service(service_type=ServiceType.ServiceRemovedEventV1, envid=envid, name=name, version=version)
86+
service_event = service.create_event(data)
9287
cdevents_command = CDeventsCommand()
93-
cdevents_command.run(new_event)
88+
cdevents_command.run(service_event)
9489

9590

9691
@click.command(help=add_disclaimer_text("Service Rolledback CloudEvent."))
@@ -102,7 +97,7 @@ def rolledback(
10297
data: List[str] = None,
10398
):
10499
print_function_args()
105-
e = Events()
106-
new_event = e.create_service_event(event_type.ServiceRolledbackEventV1, envid, name, version, data)
100+
service = Service(service_type=ServiceType.ServiceRolledbackEventV1, envid=envid, name=name, version=version)
101+
service_event = service.create_event(data)
107102
cdevents_command = CDeventsCommand()
108-
cdevents_command.run(new_event)
103+
cdevents_command.run(service_event)

core/cdevents/core/event_type.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,6 @@
99
ChangeMergedEventV1 :str = "cd.repository.change.merged.v1"
1010
ChangeAbandonedEventV1 :str = "cd.repository.change.abandoned.v1"
1111

12-
# Repository events
13-
RepositoryCreatedEventV1 :str = "cd.repository.created.v1"
14-
RepositoryModifiedEventV1 :str = "cd.repository.modified.v1"
15-
RepositoryDeletedEventV1 :str = "cd.repository.deleted.v1"
16-
17-
# Service Events
18-
ServiceDeployedEventV1 :str = "cd.service.deployed.v1"
19-
ServiceUpgradedEventV1 :str = "cd.service.upgraded.v1"
20-
ServiceRolledbackEventV1 :str = "cd.service.rolledback.v1"
21-
ServiceRemovedEventV1 :str = "cd.service.removed.v1"
22-
2312
# TaskRun events
2413
TaskRunStartedEventV1 :str = "cd.taskrun.started.v1"
2514
TaskRunFinishedEventV1 :str = "cd.taskrun.finished.v1"

core/cdevents/core/events.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,6 @@ def create_event(self, event_type: str, extensions:dict, data = {}) -> CloudEven
2323
return event
2424

2525

26-
27-
def create_service_event(self, event_type: str , envid: str, name: str, version: str, data = {}) -> CloudEvent:
28-
"""Create service event.
29-
"""
30-
31-
extensions = {
32-
"serviceenvid": envid,
33-
"servicename": name,
34-
"serviceversion": version,
35-
}
36-
37-
event = self.create_event(event_type, extensions, data)
38-
39-
return event
40-
41-
4226
def create_taskrun_event(self, event_type: str, id: str, name: str, pipelineid: str, data = {}) -> CloudEvent:
4327
"""Create taskrun event.
4428
"""

core/cdevents/core/service.py

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
"""service"""
2+
3+
from enum import Enum
4+
from cdevents.core.events import Events
5+
6+
class ServiceType(Enum):
7+
ServiceDeployedEventV1 :str = "cd.service.deployed.v1"
8+
ServiceUpgradedEventV1 :str = "cd.service.upgraded.v1"
9+
ServiceRolledbackEventV1 :str = "cd.service.rolledback.v1"
10+
ServiceRemovedEventV1 :str = "cd.service.removed.v1"
11+
12+
13+
class Service(Events):
14+
"""Service."""
15+
16+
def __init__(self, service_type: ServiceType, envid: str, name: str, version: str):
17+
"""Initializes class.
18+
"""
19+
self._event_type = service_type
20+
self._envid = envid
21+
self._name = name
22+
self._version = version
23+
24+
def create_extensions(self):
25+
"""Create extensions.
26+
"""
27+
extensions = {
28+
"serviceenvid": self._envid,
29+
"servicename": self._name,
30+
"serviceversion": self._version,
31+
}
32+
return extensions
33+
34+
def create_event(self, data: dict={}):
35+
"""Create Service event.
36+
"""
37+
extensions = self.create_extensions()
38+
event = super().create_event(event_type=self._event_type.value, extensions=extensions, data=data)
39+
return event

0 commit comments

Comments
 (0)