Skip to content

Commit 6423740

Browse files
tarekbadrshafrittoli
authored andcommitted
update abstractmethod
1 parent 3523b27 commit 6423740

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

core/cdevents/core/branch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class BranchType(Enum):
99

1010

1111
class Branch(Events):
12-
"""Brach."""
12+
"""Branch."""
1313

1414
def __init__(self, branch_type: BranchType, id: str, name: str, repoid: str, data: dict = {}):
1515
"""Initializes class.

core/cdevents/core/event_type.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@
99
ChangeMergedEventV1 :str = "cd.repository.change.merged.v1"
1010
ChangeAbandonedEventV1 :str = "cd.repository.change.abandoned.v1"
1111

12-
# Test Events
12+
# TestCase Events
1313
TestCaseStartedEventV1 :str = "cd.test.case.started.v1"
1414
TestCaseQueuedEventV1 :str = "cd.test.case.queued.v1"
1515
TestCaseFinishedEventV1 :str = "cd.test.case.finished.v1"
1616

17+
# TestSuite Events
1718
TestSuiteStartedEventV1 :str = "cd.test.suite.started.v1"
1819
TestSuiteQueuedEventV1 :str = "cd.test.suite.queued.v1"
1920
TestSuiteFinishedEventV1 :str = "cd.test.suite.finished.v1"

core/cdevents/core/events.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
"""Core events."""
22

3+
from abc import abstractmethod
34
from cloudevents.http import CloudEvent
45

56
class Events(CloudEvent):
@@ -18,3 +19,16 @@ def __init__(self, event_type: str, extensions: dict, data = {}):
1819
"extensions": self._extensions,
1920
}
2021
super().__init__(self._attributes, dict(self._data))
22+
23+
@abstractmethod
24+
def create_extensions(self) -> dict:
25+
"""Create extensions.
26+
"""
27+
extensions = {}
28+
return extensions
29+
30+
# @abstractmethod
31+
# def event_from_json(json_obj: dict) -> Events:
32+
# """Create event from json.
33+
# """
34+
# pass

0 commit comments

Comments
 (0)