Set TEMP/TMP env vars before importing pgsrip

Back to Python API - set TEMP/TMP environment variables to video
directory before importing pgsrip. This forces tempfile module to
use video directory for temp folders. Restore env vars after.

Avoids sys.executable issue where PyInstaller exe would launch
another FastFlix window when trying to run pgsrip as subprocess.

Author: mikeSGman

fastflix/widgets/background_tasks.py

@@ -232,7 +232,7 @@ def _convert_sup_to_srt(self, sup_filepath: str) -> bool:
             video_path = Path(self.main.input_video)
             video_dir = str(video_path.parent)
 
-            # Set environment variables for pgsrip CLI to find tesseract and mkvextract
+            # Set environment variables for pgsrip to find tesseract and mkvextract
             if self.app.fastflix.config.tesseract_path:
                 tesseract_dir = str(Path(self.app.fastflix.config.tesseract_path).parent)
                 os.environ["PATH"] = f"{tesseract_dir}{os.pathsep}{os.environ.get('PATH', '')}"
@@ -242,62 +242,91 @@ def _convert_sup_to_srt(self, sup_filepath: str) -> bool:
                 mkvtoolnix_dir = str(Path(self.app.fastflix.config.mkvmerge_path).parent)
                 os.environ["PATH"] = f"{mkvtoolnix_dir}{os.pathsep}{os.environ.get('PATH', '')}"
 
-            # Use pgsrip CLI instead of Python API to avoid PyInstaller temp folder issues
-            # Build pgsrip command
-            import sys
-            import subprocess
+            # CRITICAL FIX: Set TEMP/TMP to video directory before importing pgsrip
+            # This forces Python's tempfile module to use the video directory
+            original_temp = os.environ.get("TEMP")
+            original_tmp = os.environ.get("TMP")
+            os.environ["TEMP"] = video_dir
+            os.environ["TMP"] = video_dir
 
-            # Get list of existing .srt files before conversion
-            existing_srts = set(video_path.parent.glob("*.srt"))
-
-            # Call pgsrip as subprocess
-            pgsrip_cmd = [
-                sys.executable,
-                "-m",
-                "pgsrip",
-                "--languages",
-                self.language,
-                "--overwrite",
-                str(video_path),
-            ]
-
-            self.main.thread_logging_signal.emit(f"DEBUG:Running: {' '.join(pgsrip_cmd)}")
-
-            result = subprocess.run(pgsrip_cmd, capture_output=True, text=True, cwd=video_dir, env=os.environ.copy())
-
-            if result.returncode != 0:
-                raise Exception(f"pgsrip CLI failed: {result.stderr or result.stdout}")
-
-            # Find newly created .srt files
-            current_srts = set(video_path.parent.glob("*.srt"))
-            new_srts = current_srts - existing_srts
-
-            if not new_srts:
-                raise Exception(f"pgsrip completed but no .srt file found in {video_path.parent}")
-
-            # Get the first new .srt file
-            srt_files = list(new_srts)
-
-            # Move the .srt file to the expected location (same dir as .sup was)
-            created_srt = srt_files[0]
-            expected_srt = sup_path.with_suffix(".srt")
-
-            if created_srt != expected_srt:
-                # Move/rename to expected location
-                import shutil
-
-                shutil.move(str(created_srt), str(expected_srt))
-
-            self.main.thread_logging_signal.emit(f"INFO:{t('OCR conversion successful')}: {expected_srt.name}")
-
-            # Optionally delete the .sup file since we have .srt now
             try:
-                sup_path.unlink()
-                self.main.thread_logging_signal.emit(f"INFO:{t('Removed .sup file, kept .srt')}")
-            except Exception:
-                pass
-
-            return True
+                # Import pgsrip AFTER setting TEMP/TMP
+                from pgsrip import pgsrip, Mkv, Options
+                from babelfish import Language as BabelLanguage
+
+                media = Mkv(str(video_path))
+
+                # Configure options for pgsrip
+                try:
+                    # Detect if language code is 2-letter or 3-letter
+                    if len(self.language) == 2:
+                        babel_lang = BabelLanguage.fromalpha2(self.language)
+                    elif len(self.language) == 3:
+                        babel_lang = BabelLanguage(self.language)
+                    else:
+                        babel_lang = BabelLanguage.fromname(self.language)
+
+                    options = Options(
+                        languages={babel_lang},
+                        overwrite=True,
+                        one_per_lang=True,
+                    )
+                except Exception:
+                    # Fallback to English if language code is invalid
+                    options = Options(
+                        languages={BabelLanguage("eng")},
+                        overwrite=True,
+                        one_per_lang=True,
+                    )
+
+                # Get list of existing .srt files before conversion
+                existing_srts = set(video_path.parent.glob("*.srt"))
+
+                # Run pgsrip conversion using Python API
+                pgsrip.rip(media, options)
+
+                # Find newly created .srt files
+                current_srts = set(video_path.parent.glob("*.srt"))
+                new_srts = current_srts - existing_srts
+
+                if not new_srts:
+                    raise Exception(f"pgsrip completed but no .srt file found in {video_path.parent}")
+
+                # Get the first new .srt file
+                srt_files = list(new_srts)
+
+                # Move the .srt file to the expected location (same dir as .sup was)
+                created_srt = srt_files[0]
+                expected_srt = sup_path.with_suffix(".srt")
+
+                if created_srt != expected_srt:
+                    # Move/rename to expected location
+                    import shutil
+
+                    shutil.move(str(created_srt), str(expected_srt))
+
+                self.main.thread_logging_signal.emit(f"INFO:{t('OCR conversion successful')}: {expected_srt.name}")
+
+                # Optionally delete the .sup file since we have .srt now
+                try:
+                    sup_path.unlink()
+                    self.main.thread_logging_signal.emit(f"INFO:{t('Removed .sup file, kept .srt')}")
+                except Exception:
+                    pass
+
+                return True
+
+            finally:
+                # Restore original TEMP/TMP
+                if original_temp is not None:
+                    os.environ["TEMP"] = original_temp
+                elif "TEMP" in os.environ:
+                    del os.environ["TEMP"]
+
+                if original_tmp is not None:
+                    os.environ["TMP"] = original_tmp
+                elif "TMP" in os.environ:
+                    del os.environ["TMP"]
 
         except Exception as err:
             self.main.thread_logging_signal.emit(f"ERROR:{t('OCR conversion failed')}: {err}")