Version 5.11.0 (#650)

* Adding parallel encoding options for rigaya hardware encoders (thanks to Hexenhammer)
* Adding builds for Ubuntu 22.04 and mac 13 again
* Changing SVT-AV1 to single pass only due to ffmpeg not allowing passlog files properly
* Changing SVT-AV1 to CRF quantization mode by default
* Fixing #642 Possible to create a profile without bitrate specified for audio stream (thanks to Xoanon88)
* Fixing #644 various typos (thanks to luzpaz)
* Fixing #646 PydanticSerializationUnexpectedValue warning during startup (thanks to Noelle Leigh)
* Fixing #647 another typo (thanks to Noelle Leigh)
* Fixing #649 1-Pass Bitrate stored in x265 profile not honored (thanks to Xoanon88)
* Fixing how program is centered on multiple monitors
* Fixing do not pass infer_no_subs to encc encoders

---------

Co-authored-by: Noelle Leigh <[email protected]>
Co-authored-by: luzpaz <[email protected]>

Author: 3 people

.github/workflows/build.yaml

@@ -9,7 +9,7 @@ jobs:
   build-nix:
     strategy:
       matrix:
-        os: [ ubuntu-24.04, macos-14 ]
+        os: [ ubuntu-22.04, ubuntu-24.04, macos-13, macos-14 ]
     runs-on: ${{ matrix.os }}
 
     steps:

CHANGES

@@ -1,5 +1,19 @@
 # Changelog
 
+## Version 5.11.0
+
+* Adding parallel encoding options for rigaya hardware encoders (thanks to Hexenhammer)
+* Adding builds for Ubuntu 22.04 and mac 13 again
+* Changing SVT-AV1 to single pass only due to ffmpeg not allowing passlog files properly
+* Changing SVT-AV1 to CRF quantization mode by default
+* Fixing #642 Possible to create a profile without bitrate specified for audio stream (thanks to Xoanon88)
+* Fixing #644 various typos (thanks to luzpaz)
+* Fixing #646 PydanticSerializationUnexpectedValue warning during startup (thanks to Noelle Leigh)
+* Fixing #647 another typo (thanks to Noelle Leigh)
+* Fixing #649 1-Pass Bitrate stored in x265 profile not honored (thanks to Xoanon88)
+* Fixing how program is centered on multiple monitors
+* Fixing do not pass infer_no_subs to encc encoders
+
 ## Version 5.10.0
 
 * Adding global disable interlace check (thanks to Hexenhammer)

fastflix/__main__.py

@@ -23,7 +23,7 @@ def start_fastflix():
         traceback.print_exc()
         input(
             "Error while running FastFlix!\n"
-            "Plese report this issue on https://github.com/cdgriffith/FastFlix/issues (press any key to exit)"
+            "Please report this issue on https://github.com/cdgriffith/FastFlix/issues (press any key to exit)"
         )
     except KeyboardInterrupt:
         pass

fastflix/application.py

@@ -196,8 +196,7 @@ def app_setup(
         sys.exit(1)
 
     if app.fastflix.config.theme != "system":
-        QtCore.QDir.addSearchPath(app.fastflix.config.theme, str(breeze_styles_path / app.fastflix.config.theme))
-        file = QtCore.QFile(f"{app.fastflix.config.theme}:stylesheet.qss")
+        file = QtCore.QFile(str(breeze_styles_path / app.fastflix.config.theme / "stylesheet.qss"))
         file.open(QtCore.QFile.OpenModeFlag.ReadOnly | QtCore.QFile.OpenModeFlag.Text)
         stream = QtCore.QTextStream(file)
         data = stream.readAll()
@@ -233,7 +232,9 @@ def app_setup(
     container = Container(app)
     container.show()
 
-    container.move(QtGui.QGuiApplication.primaryScreen().availableGeometry().center() - container.rect().center())
+    # container.move(QtGui.QGuiApplication.primaryScreen().availableGeometry().center() - container.rect().center())
+    screen_geometry = QtGui.QGuiApplication.primaryScreen().availableGeometry()
+    container.move(screen_geometry.center() - container.rect().center())
 
     if not app.fastflix.config.disable_version_check:
         latest_fastflix(app=app, show_new_dialog=False)
@@ -257,7 +258,7 @@ def start_app(worker_queue, status_queue, log_queue, queue_list, queue_lock, por
     )
 
     try:
-        app.exec_()
+        app.exec()
     except Exception:
         logger.exception("Error while running FastFlix")
         raise

fastflix/data/languages.yaml

@@ -10757,3 +10757,33 @@ Automatically download FFmpeg?:
   ukr: Автоматично завантажити FFmpeg?
   kor: FFmpeg를 자동으로 다운로드하시겠습니까?
   ron: Descărcați automat FFmpeg?
+Parallel Encoding:
+  eng: Parallel Encoding
+  deu: Parallele Kodierung
+  fra: Encodage parallèle
+  ita: Codifica parallela
+  spa: Codificación paralela
+  jpn: パラレル・エンコーディング
+  rus: Параллельное кодирование
+  por: Codificação paralela
+  swe: Parallell kodning
+  pol: Kodowanie równoległe
+  chs: 并行编码
+  ukr: Паралельне кодування
+  kor: 병렬 인코딩
+  ron: Codificare paralelă
+Enable either auto split or parallel encoding mode.:
+  eng: Enable either auto split or parallel encoding mode.
+  deu: Aktivieren Sie entweder die automatische Aufteilung oder den parallelen Codierungsmodus.
+  fra: Activer le mode d'encodage auto split ou parallèle.
+  ita: Abilitare la modalità di codifica automatica o parallela.
+  spa: Habilita el modo de división automática o de codificación paralela.
+  jpn: 自動分割またはパラレルエンコーディングモードのいずれかを有効にする。
+  rus: Включите режим автоматического разделения или параллельного кодирования.
+  por: Ativar o modo de codificação automática ou paralela.
+  swe: Aktivera antingen auto split eller parallell kodning.
+  pol: Włącz tryb automatycznego podziału lub kodowania równoległego.
+  chs: 启用自动分割或并行编码模式。
+  ukr: Увімкніть режим автоматичного розділення або паралельного кодування.
+  kor: 자동 분할 또는 병렬 인코딩 모드를 활성화합니다.
+  ron: Activați divizarea automată sau modul de codare paralelă.

fastflix/encoders/common/encc_helpers.py

@@ -184,5 +184,5 @@ def build_subtitle(subtitle_tracks: list[SubtitleTrack], subtitle_streams, video
 
     commands = f" --sub-copy {','.join(copies)} {' '.join(command_list)}" if copies else f" {' '.join(command_list)}"
     if commands:
-        return f"{commands} -m default_mode:infer_no_subs"
+        return commands
     return ""

fastflix/encoders/common/setting_panel.py

@@ -346,7 +346,10 @@ def _add_modes(
         disable_custom_qp=False,
         show_bitrate_passes=False,
         disable_bitrate=False,
+        qp_display_name=None,
     ):
+        if not qp_display_name:
+            qp_display_name = qp_name.upper()
         self.recommended_bitrates = recommended_bitrates
         self.recommended_qps = recommended_qps
         self.qp_name = qp_name
@@ -372,7 +375,6 @@ def _add_modes(
             self.widgets.bitrate.addItems(recommended_bitrates)
             self.widgets.bitrate_passes = QtWidgets.QComboBox()
             self.widgets.bitrate_passes.addItems(["1", "2"])
-            self.widgets.bitrate_passes.setCurrentIndex(1)
             self.widgets.bitrate_passes.currentIndexChanged.connect(lambda: self.mode_update())
             config_opt = self.app.fastflix.config.encoder_opt(self.profile_name, "bitrate")
             custom_bitrate = False
@@ -396,14 +398,17 @@ def _add_modes(
             bitrate_box_layout.addWidget(self.widgets.bitrate, 1)
             bitrate_box_layout.addStretch(1)
             if show_bitrate_passes:
+                self.widgets.bitrate_passes.setCurrentIndex(
+                    int(self.app.fastflix.config.encoder_opt(self.profile_name, "bitrate_passes")) - 1
+                )
                 bitrate_box_layout.addWidget(QtWidgets.QLabel(t("Passes") + ":"))
                 bitrate_box_layout.addWidget(self.widgets.bitrate_passes)
             bitrate_box_layout.addStretch(1)
             bitrate_box_layout.addWidget(QtWidgets.QLabel(t("Custom") + ":"))
             bitrate_box_layout.addWidget(self.widgets.custom_bitrate)
             bitrate_box_layout.addWidget(QtWidgets.QLabel("k"))
 
-            self.qp_radio = QtWidgets.QRadioButton(qp_name.upper())
+            self.qp_radio = QtWidgets.QRadioButton(qp_display_name)
             self.qp_radio.setChecked(True)
             self.qp_radio.setFixedWidth(80)
             self.qp_radio.setToolTip(qp_help)
@@ -653,6 +658,18 @@ def init_dhdr10_info(self):
         )
         return layout
 
+    def init_parallel_mode(self, add_split=False):
+        options = ["none", "parallel"]
+        if add_split:
+            options.insert(1, "split")
+        return self._add_combo_box(
+            label="Parallel Encoding",
+            widget_name="split_mode",
+            options=options,
+            opt="split_mode",
+            tooltip="Enable either auto split or parallel encoding mode.",
+        )
+
 
 class QSVEncPanel(RigayaPanel):
     def init_adapt_ref(self):

fastflix/encoders/hevc_x265/settings_panel.py

@@ -566,7 +566,8 @@ def init_modes(self):
         return self._add_modes(recommended_bitrates, recommended_crfs, qp_name="crf", show_bitrate_passes=True)
 
     def mode_update(self):
-        self.widgets.custom_crf.setDisabled(self.widgets.crf.currentText() != "Custom")
+        if "custom_crf" in self.widgets:
+            self.widgets.custom_crf.setDisabled(self.widgets.crf.currentText() != "Custom")
         self.widgets.custom_bitrate.setDisabled(self.widgets.bitrate.currentText() != "Custom")
         self.main.build_commands()
 

fastflix/encoders/nvencc_av1/command_builder.py

@@ -105,6 +105,12 @@ def build(fastflix: FastFlix):
 
     source_fps = f"--fps {video.video_settings.source_fps}" if video.video_settings.source_fps else ""
 
+    split_mode = ""
+    if settings.split_mode == "split":
+        split_mode = f"--split-enc auto_forced"
+    elif settings.split_mode == "parallel":
+        split_mode = f"--parallel auto"
+
     command = [
         f'"{clean_file_string(fastflix.config.nvencc)}"',
         rigaya_avformat_reader(fastflix),
@@ -160,6 +166,7 @@ def build(fastflix: FastFlix):
         (f"--interlace {video.interlaced}" if video.interlaced and video.interlaced != "False" else ""),
         ("--vpp-yadif" if video.video_settings.deinterlace else ""),
         remove_hdr,
+        split_mode,
         "--psnr --ssim" if settings.metrics else "",
         build_audio(video.audio_tracks, video.streams.audio),
         build_subtitle(video.subtitle_tracks, video.streams.subtitle, video_height=video.height),

fastflix/encoders/nvencc_av1/settings_panel.py

@@ -128,7 +128,8 @@ def __init__(self, parent, main, app: FastFlixApp):
         even_more.addLayout(self.init_metrics())
         grid.addLayout(even_more, 7, 2, 1, 4)
 
-        grid.addLayout(self.init_dhdr10_info(), 8, 2, 1, 4)
+        grid.addLayout(self.init_dhdr10_info(), 8, 2, 1, 2)
+        grid.addLayout(self.init_parallel_mode(add_split=True), 8, 4, 1, 2)
 
         grid.setRowStretch(9, 1)
 
@@ -415,6 +416,7 @@ def update_video_encoder_settings(self):
             b_ref_mode=self.widgets.b_ref_mode.currentText(),
             device=int(self.widgets.device.currentText().split(":", 1)[0] or 0),
             decoder=self.widgets.decoder.currentText(),
+            split_mode=self.widgets.split_mode.currentText(),
         )
 
         encode_type, q_value = self.get_mode_settings()