Removing all warnings during testing

Author: cdgriffith

.github/workflows/tests.yaml

@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.5, 3.6, 3.7, 3.8]
+        python-version: [ 3.6, 3.7, 3.8 ]
 
     steps:
     - uses: actions/checkout@v2

reusables/cli.py

@@ -159,18 +159,15 @@ def cat(file_path, encoding="utf-8", errors="strict"):
              /  \\
             |    |   _/
             | || |  |
-            \_||_/_/
+            |_||_/_/
 
     :param file_path: Path to file to read
     :param encoding: defaults to utf-8 to decode as, will fail on binary
     :param errors: Decoding errors: 'strict', 'ignore' or 'replace'
     """
 
-    with open(file_path, "rb") as f:
-        if python_version >= (2, 7):
-            print(f.read().decode(encoding, errors=errors))
-        else:
-            print(f.read().decode(encoding))
+    with open(file_path, "r", encoding=encoding, errors=errors) as f:
+        print(f.read())
 
 
 def tail(file_path, lines=10, encoding="utf-8", printed=True, errors="strict"):
@@ -189,10 +186,7 @@ def tail(file_path, lines=10, encoding="utf-8", printed=True, errors="strict"):
 
     with open(file_path, "rb") as f:
         for line in f:
-            if python_version >= (2, 7):
-                data.append(line.decode(encoding, errors=errors))
-            else:
-                data.append(line.decode(encoding))
+            data.append(line.decode(encoding, errors=errors))
             if len(data) > lines:
                 data.popleft()
     if printed:

reusables/wrappers.py

@@ -253,7 +253,7 @@ def test():
         # 2016-12-26 12:38:01,381 - reusables   ERROR  Exception in test - Bad
         # Traceback (most recent call last):
         #     File "<input>", line 1, in <module>
-        #     File "reusables\wrappers.py", line 200, in wrapper
+        #     File "reusables/wrappers.py", line 200, in wrapper
         #     raise err
         # Exception: Bad
 

test/test_reuse.py

@@ -6,6 +6,7 @@
 import subprocess
 
 import reusables
+import pytest
 
 from .common_test_data import *
 
@@ -431,6 +432,7 @@ def test_duplicate_dir(self):
         dups = reusables.directory_duplicates(test_root)
         assert len(dups) == 1, len(dups)
 
+    @pytest.mark.filterwarnings('ignore:"enable_scandir"')
     def test_find(self):
         resp = reusables.find_files_list(test_root, ext=[".cfg", ".nope"], disable_pathlib=True, enable_scandir=True)
         assert [x for x in resp if x.endswith(os.path.join(test_root, "test_config.cfg"))]

test/test_sanitized_input.py

@@ -11,7 +11,7 @@
 from .common_test_data import *
 
 
-class TestException(Exception):
+class ReuseTestException(Exception):
     pass
 
 
@@ -20,7 +20,7 @@ def __init__(self, value):
         if isinstance(value, str):
             self.value = int(value)
         else:
-            raise TestException("Exception")
+            raise ReuseTestException("Exception")
 
 
 class TestSanitizedInput(BaseTestClass):
@@ -58,7 +58,7 @@ def test_cast_as(self):
             "raise_on_invalid": False,
         }
         with mock.patch("reusables.sanitizers._get_input", return_value=1):
-            self.assertRaises(TestException, reusables.sanitized_input, **kwargs)
+            self.assertRaises(ReuseTestException, reusables.sanitized_input, **kwargs)
         with mock.patch("reusables.sanitizers._get_input", return_value="1"):
             assert isinstance(reusables.sanitized_input(cast_as=IntVar), IntVar), "Success"
             assert not isinstance(reusables.sanitized_input(cast_as=IntVar), int), "Failure"