-Wall -Wextra has tons of warnings

[rcurtin]

Suppose that I am using CHDL in something else, and I am interested in guaranteeing that the code doesn't have warnings.

This can be easily reproduced by setting CXXFLAGS="-Wall -Wextra" and typing 'make'. Here is an excerpt of the output:

g++ -Wall -Wextra -fPIC -std=c++11 -O2    -c -o hierarchy.o hierarchy.cpp
In file included from regimpl.h:5:0,
                 from hierarchy.cpp:14:
tickable.h:20:18: warning: unused parameter âcdâ [-Wunused-parameter]
tickable.h:21:18: warning: unused parameter âcdâ [-Wunused-parameter]
tickable.h:22:18: warning: unused parameter âcdâ [-Wunused-parameter]
tickable.h:23:18: warning: unused parameter âcdâ [-Wunused-parameter]
In file included from hierarchy.cpp:14:0:
regimpl.h:20:10: warning: unused parameter âcdâ [-Wunused-parameter]
hierarchy.cpp: In constructor âhierarchy::hierarchy(std::string, chdl::hpath_t)â:
hierarchy.cpp:55:10: warning: âhierarchy::nameâ will be initialized after [-Wreorder]
hierarchy.cpp:54:11: warning:   âchdl::hpath_t hierarchy::pathâ [-Wreorder]
hierarchy.cpp:21:3: warning:   when initialized here [-Wreorder]
hierarchy.cpp: In member function âvoid hierarchy::print(std::ostream&, int, unsigned int)â:
hierarchy.cpp:30:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

This bug is important because users expect their code to compile cleanly without warnings, especially upstream projects that are subject to distribution requirements for -Wall and -Wextra.

[ZoogieZork]

FWIW, I do agree about the -Wreorder warnings.

[rcurtin]

A couple other warnings I found include -Wunused-function (probably does not matter), -Wdelete-non-virtual-dtor which is probably worth looking into, a few -Wsign-compare which are a bit pedantic but probably worth your time, and a -Wreturn-type for a function that could end without returning anything. Maybe they matter, maybe they don't, but hey, I helped open source, right? Or something.

[cdkersey]

Oops. Didn't mean to close it. Not going to fix this, especially not for -Wextra, but not going to close this either. I'll let it smolder and see what kinds of fixes for warnings we accumulate. Some of these are doubleplus annoying because they appear in the default warning sets on strange compilers/platforms.

[rcurtin]

From #9, this comment wasn't addressed:

I fixed some more -Wunused because why not. There are a few statements of the form

if(type* r = dynamic_cast<type*>(something));

with r unused. Are these equivalent to if(dynamic_cast<type*>(something))? I didn't test.

Depending on your assessment I'll happily make the gruntwork changes.

[cdkersey]

Are these equivalent to if(dynamic_cast(something))?

Yes. Feel free to remove the unused variable declarations from those predicates. The only reason I can fathom they're there is that they were used for debugging during development and left in.