Skip to content

Commit 07d9896

Browse files
author
Eugene Cheung
authored
fix: use LESS_THAN_THRESHOLD for addMinUsageCountAlarm (#318)
`LESS_THAN_LOWER_THRESHOLD` is for: ``` * Specified statistic is lower than the anomaly model band. * Used only for alarms based on anomaly detection models ``` ...which is not what it was being used for. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
1 parent fdd5ac1 commit 07d9896

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

lib/common/monitoring/alarms/UsageAlarmFactory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export class UsageAlarmFactory {
4747
props.treatMissingDataOverride ?? TreatMissingData.MISSING,
4848
comparisonOperator:
4949
props.comparisonOperatorOverride ??
50-
ComparisonOperator.LESS_THAN_LOWER_THRESHOLD,
50+
ComparisonOperator.LESS_THAN_THRESHOLD,
5151
...props,
5252
disambiguator,
5353
threshold: props.minCount,

test/monitoring/aws-cloudwatch/__snapshots__/LogMonitoring.test.ts.snap

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/monitoring/aws-lambda/__snapshots__/LambdaFunctionMonitoring.test.ts.snap

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)