fix(loadbalancing): fix duplicate summary graphs for NLBs (#175)

Reported by a customer.

Also adding dashboard snapshots to the `aws-loadbalancing` tests.

---

_By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_

Author: Eugene Cheung

lib/monitoring/aws-loadbalancing/NetworkLoadBalancerMonitoring.ts

@@ -148,7 +148,7 @@ export class NetworkLoadBalancerMonitoring extends Monitoring {
   summaryWidgets(): IWidget[] {
     return [
       this.createTitleWidget(),
-      this.createTaskHealthWidget(HalfWidth, DefaultSummaryWidgetHeight),
+      this.createTcpFlowsWidget(HalfWidth, DefaultSummaryWidgetHeight),
       this.createTaskHealthWidget(HalfWidth, DefaultSummaryWidgetHeight),
     ];
   }

test/monitoring/aws-loadbalancing/ApplicationLoadBalancerMonitoring.test.ts

@@ -17,6 +17,7 @@ import {
   Ec2ServiceMonitoring,
   FargateServiceMonitoring,
 } from "../../../lib";
+import { addMonitoringDashboardsToStack } from "../../utils/SnapshotUtil";
 import { TestMonitoringScope } from "../TestMonitoringScope";
 
 // FARGATE SERVICE
@@ -46,13 +47,14 @@ test("snapshot alb test: no alarms", () => {
     .addListener("Listener", { port: 80 })
     .addTargets("Target", { port: 80, targets: [fargateService] });
 
-  new FargateServiceMonitoring(scope, {
+  const monitoring = new FargateServiceMonitoring(scope, {
     fargateService,
     loadBalancer: applicationLoadBalancer,
     targetGroup: applicationTargetGroup,
     alarmFriendlyName: "DummyFargateService",
   });
 
+  addMonitoringDashboardsToStack(stack, monitoring);
   expect(Template.fromStack(stack)).toMatchSnapshot();
 });
 
@@ -82,7 +84,7 @@ test("snapshot alb test: all alarms", () => {
 
   let numAlarmsCreated = 0;
 
-  new FargateServiceMonitoring(scope, {
+  const monitoring = new FargateServiceMonitoring(scope, {
     fargateService,
     loadBalancer: applicationLoadBalancer,
     targetGroup: applicationTargetGroup,
@@ -129,6 +131,7 @@ test("snapshot alb test: all alarms", () => {
     },
   });
 
+  addMonitoringDashboardsToStack(stack, monitoring);
   expect(numAlarmsCreated).toStrictEqual(7);
   expect(Template.fromStack(stack)).toMatchSnapshot();
 });
@@ -164,13 +167,14 @@ test("snapshot ec2 alb test: no alarms", () => {
     .addListener("Listener", { port: 80 })
     .addTargets("Target", { port: 80, targets: [ec2Service] });
 
-  new Ec2ServiceMonitoring(scope, {
+  const monitoring = new Ec2ServiceMonitoring(scope, {
     ec2Service,
     loadBalancer: applicationLoadBalancer,
     targetGroup: applicationTargetGroup,
     alarmFriendlyName: "DummyEc2Service",
   });
 
+  addMonitoringDashboardsToStack(stack, monitoring);
   expect(Template.fromStack(stack)).toMatchSnapshot();
 });
 
@@ -203,7 +207,7 @@ test("snapshot ec2 alb test: all alarms", () => {
 
   let numAlarmsCreated = 0;
 
-  new Ec2ServiceMonitoring(scope, {
+  const monitoring = new Ec2ServiceMonitoring(scope, {
     ec2Service,
     loadBalancer: applicationLoadBalancer,
     targetGroup: applicationTargetGroup,
@@ -250,6 +254,7 @@ test("snapshot ec2 alb test: all alarms", () => {
     },
   });
 
+  addMonitoringDashboardsToStack(stack, monitoring);
   expect(numAlarmsCreated).toStrictEqual(7);
   expect(Template.fromStack(stack)).toMatchSnapshot();
 });

test/monitoring/aws-loadbalancing/NetworkLoadBalancerMonitoring.test.ts

@@ -7,6 +7,7 @@ import {
   AlarmWithAnnotation,
   NetworkLoadBalancerMonitoring,
 } from "../../../lib";
+import { addMonitoringDashboardsToStack } from "../../utils/SnapshotUtil";
 import { TestMonitoringScope } from "../TestMonitoringScope";
 
 test("snapshot nlb test: no alarms", () => {
@@ -22,12 +23,13 @@ test("snapshot nlb test: no alarms", () => {
     .addListener("Listener", { port: 80 })
     .addTargets("Target", { port: 80 });
 
-  new NetworkLoadBalancerMonitoring(scope, {
+  const monitoring = new NetworkLoadBalancerMonitoring(scope, {
     networkLoadBalancer,
     networkTargetGroup,
     alarmFriendlyName: "DummyNetworkLoadBalancer",
   });
 
+  addMonitoringDashboardsToStack(stack, monitoring);
   expect(Template.fromStack(stack)).toMatchSnapshot();
 });
 
@@ -46,7 +48,7 @@ test("snapshot nlb test: all alarms", () => {
 
   let numAlarmsCreated = 0;
 
-  new NetworkLoadBalancerMonitoring(scope, {
+  const monitoring = new NetworkLoadBalancerMonitoring(scope, {
     networkLoadBalancer,
     networkTargetGroup,
     alarmFriendlyName: "DummyNetworkLoadBalancer",
@@ -77,6 +79,7 @@ test("snapshot nlb test: all alarms", () => {
     },
   });
 
+  addMonitoringDashboardsToStack(stack, monitoring);
   expect(numAlarmsCreated).toStrictEqual(4);
   expect(Template.fromStack(stack)).toMatchSnapshot();
 });