Skip to content

Commit 8e1f062

Browse files
authored
fix(sqs): fix sqs message age and min incoming dedupe (#540)
Our team has a variety of SQS alarms including tiered alarm on message ages and tiered alarms based on how long we haven't seen messages in. However, these are not currently deduping as expected which we root caused to the `alarmDedupeStringSuffix` being missing on these alarms. The message age issue is reported in #255. This PR fixes both #255 and the unreported minute incoming messages issue by adding `alarmDedupeStringSuffix` for them. Fixes #255 --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
1 parent b8f920f commit 8e1f062

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/common/monitoring/alarms/QueueAlarmFactory.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ export class QueueAlarmFactory {
9898
threshold: props.maxAgeInSeconds,
9999
alarmNameSuffix: "Queue-Message-Age-Max",
100100
alarmDescription: `Age of the oldest message in the queue is too high.`,
101+
// we will dedupe any kind of message age issue to the same ticket
102+
alarmDedupeStringSuffix: "AnyQueueMessageAge",
101103
});
102104
}
103105

@@ -136,6 +138,8 @@ export class QueueAlarmFactory {
136138
threshold: props.minIncomingMessagesCount,
137139
alarmNameSuffix: "Queue-Incoming-Messages-Count-Min",
138140
alarmDescription: `Number of incoming messages into the queue is too low.`,
141+
// we will dedupe any kind of min message issues to the same ticket
142+
alarmDedupeStringSuffix: "AnyQueueMinIncomingMessages",
139143
});
140144
}
141145

0 commit comments

Comments
 (0)