Skip to content

Commit 957e173

Browse files
authored
fix(kinesis): set required dimensions for Firehose quota metrics (#378)
According to AWS Docs [here](https://docs.aws.amazon.com/firehose/latest/dev/monitoring-with-cloudwatch-metrics.html), all firehose metrics require 'DeliveryStreamName' for filtering, this include Bytes, Records and PutRequest Per Second Limit metrics. Fixes bug where firehose quota limits metrics not working. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
1 parent e9cb81c commit 957e173

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/monitoring/aws-kinesis/KinesisFirehoseMetricFactory.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export class KinesisFirehoseMetricFactory {
151151
"BytesPerSecondLimit",
152152
MetricStatistic.AVERAGE,
153153
"Incoming Bytes/s Limit",
154-
undefined,
154+
this.dimensionsMap,
155155
undefined,
156156
FirehoseNamespace
157157
);
@@ -162,7 +162,7 @@ export class KinesisFirehoseMetricFactory {
162162
"RecordsPerSecondLimit",
163163
MetricStatistic.AVERAGE,
164164
"Records/s Limit",
165-
undefined,
165+
this.dimensionsMap,
166166
undefined,
167167
FirehoseNamespace
168168
);
@@ -173,7 +173,7 @@ export class KinesisFirehoseMetricFactory {
173173
"PutRequestsPerSecondLimit",
174174
MetricStatistic.AVERAGE,
175175
"PutRequests/s Limit",
176-
undefined,
176+
this.dimensionsMap,
177177
undefined,
178178
FirehoseNamespace
179179
);

test/monitoring/aws-kinesis/__snapshots__/KinesisFirehoseMonitoring.test.ts.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)