Skip to content

Commit ed05fda

Browse files
authored
fix: fixed TPS widget axis labels (#128)
Found some TPS axes that had invalid (Count-based) label. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
1 parent 7fba7d3 commit ed05fda

File tree

6 files changed

+21
-21
lines changed

6 files changed

+21
-21
lines changed

lib/common/metric/MetricFactory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ export class MetricFactory {
334334
labelPrefix === "Invocations" ||
335335
labelPrefix === "Transactions"
336336
) {
337-
// currently kept as "TPS" to reduce number of snapshot changes
337+
// currently, kept as "TPS" to reduce number of snapshot changes
338338
perSecondLabel = `TPS${labelAppendix}`;
339339
}
340340
return this.createMetricMath(

lib/monitoring/aws-apigatewayv2/ApiGatewayV2HttpApiMonitoring.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ export class ApiGatewayV2HttpApiMonitoring extends Monitoring {
369369
height,
370370
title: "TPS",
371371
left: [this.tpsMetric],
372-
leftYAxis: CountAxisFromZero,
372+
leftYAxis: RateAxisFromZero,
373373
leftAnnotations: this.tpsAnnotations,
374374
});
375375
}

lib/monitoring/aws-cloudfront/CloudFrontDistributionMonitoring.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
import {
88
AlarmFactory,
99
BaseMonitoringProps,
10-
CountAxisFromZero,
1110
DefaultGraphWidgetHeight,
1211
DefaultSummaryWidgetHeight,
1312
ErrorAlarmFactory,
@@ -184,7 +183,7 @@ export class CloudFrontDistributionMonitoring extends Monitoring {
184183
height,
185184
title: "TPS",
186185
left: [this.tpsMetric],
187-
leftYAxis: CountAxisFromZero,
186+
leftYAxis: RateAxisFromZero,
188187
leftAnnotations: this.tpsAnnotations,
189188
});
190189
}

lib/monitoring/aws-lambda/LambdaFunctionMonitoring.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ export class LambdaFunctionMonitoring extends Monitoring {
522522
height,
523523
title: "TPS",
524524
left: [this.tpsMetric],
525-
leftYAxis: CountAxisFromZero,
525+
leftYAxis: RateAxisFromZero,
526526
leftAnnotations: this.tpsAnnotations,
527527
});
528528
}

lib/monitoring/aws-opensearch/OpenSearchClusterMonitoring.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
OpenSearchKmsKeyInaccessibleThreshold,
2727
PercentageAxisFromZeroToHundred,
2828
QuarterWidth,
29+
RateAxisFromZero,
2930
ThirdWidth,
3031
TimeAxisMillisFromZero,
3132
UsageAlarmFactory,
@@ -402,7 +403,7 @@ export class OpenSearchClusterMonitoring extends Monitoring {
402403
height: DefaultSummaryWidgetHeight,
403404
title: "TPS",
404405
left: [this.tpsMetric],
405-
leftYAxis: CountAxisFromZero,
406+
leftYAxis: RateAxisFromZero,
406407
}),
407408
// Indexing latency
408409
new GraphWidget({
@@ -467,7 +468,7 @@ export class OpenSearchClusterMonitoring extends Monitoring {
467468
height: DefaultGraphWidgetHeight,
468469
title: "TPS",
469470
left: [this.tpsMetric],
470-
leftYAxis: CountAxisFromZero,
471+
leftYAxis: RateAxisFromZero,
471472
}),
472473
// Indexing latency
473474
new GraphWidget({

test/facade/__snapshots__/MonitoringAspect.test.ts.snap

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)