Skip to content

Commit 0799d0b

Browse files
fix: upgrades to jsii-docgen don't trigger releases (#1795)
Construct hub is currently experiencing failures like these: ```console Error loading assembly from file /tmp/zENg8p/node_modules/projen/.jsii:\nError: This jsii tool cannot load the given assembly; using unsupported feature(s): class-covariant-overrides (supported features: intersection-types) ``` This error was resolved in https://github.com/cdklabs/jsii-docgen/releases/tag/v10.11.0, which was released on Oct 23. However, construct hub [latest release](https://github.com/cdklabs/construct-hub/releases/tag/v0.4.423) is from Oct 17 so we don't have a version of construct hub who's bundles use this new version. This PR will trigger a release (because its a `fix`) as well as ensure future dev upgrades will trigger a release as well. ### Note Not all dev dependencies participate in our bundling process (namely test packages) - but we don't currently have a mechanism to trigger releases on specific package upgrades. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent d2abded commit 0799d0b

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

.projen/tasks.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.projenrc.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { join, relative } from 'path';
22
import { CdklabsConstructLibrary } from 'cdklabs-projen-project-types';
3-
import { github } from 'projen';
3+
import { github, ReleasableCommits } from 'projen';
44
import { addDevApp } from './projenrc/dev-app';
55
import { discoverEcsTasks } from './projenrc/magic-ecs';
66
import { discoverLambdas } from './projenrc/magic-lambda';
@@ -17,6 +17,13 @@ const peerDeps = [
1717

1818
const cdkCli = 'aws-cdk@^2';
1919

20+
const releasableCommitsCmd = [
21+
ReleasableCommits.featuresAndFixes().cmd,
22+
23+
// dev dependencies affect our bundles
24+
"'chore\\(deps\\): upgrade dev dependencies'",
25+
];
26+
2027
const project = new CdklabsConstructLibrary({
2128
cdkVersion,
2229
setNodeEngineVersion: false,
@@ -109,6 +116,9 @@ const project = new CdklabsConstructLibrary({
109116
enablePRAutoMerge: true,
110117

111118
releaseToNpm: true,
119+
releasableCommits: ReleasableCommits.exec(
120+
releasableCommitsCmd.join(' --grep ')
121+
),
112122
cdklabsPublishingDefaults: false,
113123

114124
publishToGo: undefined,

0 commit comments

Comments
 (0)