Commit c105661
fix(package-sources): adjust canary alarm timing to match hourly execution (#1813)
Adjusts the NPM.js canary alarm timing configuration to properly trigger
when the SLA is breached.
## Problem
The previous configuration would never trigger the alarm. With a 5
minute period and 4 evaluation periods, the alarm would evaluate over a
20 minute window. However, the canary runs once per hour, meaning
CloudWatch only receives metrics hourly. Since we treat missing data
points as not breaching, there would never be enough data points to
evaluate 4 periods before the next canary run, preventing the alarm from
ever triggering.
## Solution
The new configuration uses a 10 minute period with 1 evaluation period.
This triggers the alarm immediately when a canary run reports metrics
exceeding the SLA threshold. Since exceeding the SLA is itself a breach,
there's no need to wait for multiple data points. The 10 minute period
provides quick detection while accounting for potential drift in the
hourly canary schedule.
----
*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
---------
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>1 parent 363b53a commit c105661
File tree
3 files changed
+38
-39
lines changed- src
- __tests__
- __snapshots__
- devapp/__snapshots__
- package-sources
3 files changed
+38
-39
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
606 | 606 | | |
607 | 607 | | |
608 | 608 | | |
609 | | - | |
610 | | - | |
| 609 | + | |
611 | 610 | | |
612 | 611 | | |
613 | 612 | | |
| |||
622 | 621 | | |
623 | 622 | | |
624 | 623 | | |
625 | | - | |
| 624 | + | |
626 | 625 | | |
627 | 626 | | |
628 | 627 | | |
| |||
0 commit comments