Skip to content

Commit 9f40386

Browse files
authored
chore: disable type checking of libs (#1673)
`commit-and-tag-version@12` depends on a version of `lru-cache`, which fails typechecking of its definition files on modern TypeScript versions. Disable lib checking to get the build to pass.
1 parent e7c9e9d commit 9f40386

File tree

6 files changed

+41
-15
lines changed

6 files changed

+41
-15
lines changed

.projen/deps.json

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.projenrc.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,18 @@ const project = new cdklabs.CdklabsTypeScriptProject({
3232
],
3333
enablePRAutoMerge: true,
3434
setNodeEngineVersion: false,
35+
tsconfig: {
36+
compilerOptions: {
37+
// Conflict between `commit-and-tag-version@12` and modern TypeScript.
38+
// `commit-and-tag-version` depends on an old version of lru-cache, which TypeScript
39+
// doesn't agree with the typings of. Skip checking those files to make the build succeed.
40+
skipLibCheck: true,
41+
},
42+
},
3543
});
3644

3745
// Necessary to work around a typing issue in transitive dependency lru-cache@10 now that we've moved to a modern TS
38-
project.package.addPackageResolutions('lru-cache@^11');
46+
// project.package.addPackageResolutions('lru-cache@^11');
3947

4048
// we can't use 9.x because it doesn't work with node 10.
4149
const fsExtraVersion = '^8.0.0';

package.json

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tsconfig.dev.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tsconfig.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

yarn.lock

Lines changed: 28 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)