Refactor function declarations into headers

Author: cdlewis

DECOMPILATION_LEARNINGS.md

@@ -529,3 +529,16 @@ when a `0x3C` stride view advanced from the `Player` base and a second typed vie
 offset `0x38`; iterating `Player.bodyPartDisplayObjects` directly added two instructions. A small documented adapter
 view can preserve this induction shape while the function signatures and all actual field accesses continue using
 the canonical `Player` and `DisplayListObject` types.
+
+## Preserve Historical ABIs When Centralizing Prototypes
+
+Moving local extern declarations into shared headers can change KMC GCC output even when a caller ignores the
+return value. `onTrickCompletedHook` has an empty body and behaves like a `void` hook, but its original `s16`
+prototype affects instruction scheduling in `beginPostTrickSlidingStep`. Changing the declaration to `void`
+reordered three stores and broke 12 ROM bytes. Keep the historical non-void ABI and narrowly suppress the
+checker warning on the empty implementation.
+
+Argument signedness is similarly codegen-sensitive at call sites. For example, the final render-flags argument
+to `setupAndEnqueueSprite` and the cutscene frame index must retain their signed types so callers emit the target
+sign-extension sequence. When factoring headers, derive prototypes from both the definition and caller
+assembly rather than widening small integer arguments to a convenient unsigned type.

include/animation/model_scale.h

@@ -0,0 +1,7 @@
+#pragma once
+
+#include "common.h"
+
+typedef struct ModelScaleAnimationState ModelScaleAnimationState;
+
+void initModelScaleAnimation(ModelScaleAnimationState *state);

include/animation/model_transition.h

@@ -0,0 +1,7 @@
+#pragma once
+
+#include "common.h"
+
+typedef struct ModelTransitionEffectState ModelTransitionEffectState;
+
+void initModelTransitionEffect(ModelTransitionEffectState *state);

include/animation/pulsing_indicator.h

@@ -0,0 +1,7 @@
+#pragma once
+
+#include "common.h"
+
+typedef struct PulsingSpriteState PulsingSpriteState;
+
+void initPulsingSpriteIndicator(PulsingSpriteState *state);

include/animation/stepped_matrix.h

@@ -0,0 +1,7 @@
+#pragma once
+
+#include "common.h"
+
+typedef struct SteppedMatrixState SteppedMatrixState;
+
+void initSteppedMatrixController(SteppedMatrixState *state);

include/cutscene/1DD170.h

@@ -3,6 +3,17 @@
 #include "common.h"
 #include "cutscene/cutscene_manager.h"
 
+typedef struct CurrentCommand CurrentCommand;
+typedef struct CommandData CommandData;
+
 s32 getCategorySkipValue(u8 categoryIndex);
 s32 initializeSlotState(StateEntry *state, CutsceneManager *cutsceneManager, s8 slotIndex);
 s32 updateSlotData(CutsceneManager *cutsceneManager, s8 slotIndex);
+
+void initializeCutsceneCommand(
+    CurrentCommand *currentCommand,
+    CommandData *commandData,
+    u8 commandCategory,
+    u8 commandIndex,
+    s8 frameIndex
+);

include/cutscene/cutscene_manager.h

@@ -7,6 +7,15 @@
 #include "math/geometry.h"
 #include "ui/level_preview_3d.h"
 
+typedef union {
+    s32 value;
+    struct {
+        u8 unused;
+        u8 alpha;
+        u8 fractional[2];
+    } bytes;
+} CutsceneAlphaFixed;
+
 typedef struct {
     u8 r;
     u8 g;
@@ -41,7 +50,7 @@ typedef struct {
         struct {
             s16 remainingFrames;
             u8 padding[0xE];
-            s32 currentAlphaFixed;
+            CutsceneAlphaFixed currentAlphaFixed;
             s32 easingParam0;
             s32 easingParam1;
             s32 easingParam2;
@@ -300,7 +309,7 @@ typedef struct {
         struct {
             s16 remainingFrames;
             u8 padding[0xE];
-            s32 currentAlphaFixed;
+            CutsceneAlphaFixed currentAlphaFixed;
             s32 easingParam0;
             s32 easingParam1;
             s32 easingParam2;

include/effects/orbital_sprite.h

@@ -0,0 +1,7 @@
+#pragma once
+
+#include "common.h"
+
+typedef struct OrbitalSpriteRingInitArg OrbitalSpriteRingInitArg;
+
+void initOrbitalSpriteRing(OrbitalSpriteRingInitArg *state);

include/graphics/displaylist.h

@@ -260,3 +260,6 @@ typedef struct {
 } MatrixEntry_202A0;
 void enqueueRotatedBillboardSprite(s32 arg0, MatrixEntry_202A0 *arg1);
 void renderRotatedBillboardSpriteCI(MatrixEntry_202A0 *arg1);
+
+s32 normalizeSurfaceType(s32);
+s32 projectPositionOntoTrackSegment(TrackGeometryData *trackGeom, u16 sectorIdx, PositionXZ *pos);

include/graphics/preview_render.h

@@ -0,0 +1,18 @@
+#pragma once
+
+#include "common.h"
+
+void initBoardShopBoardIcons(void);
+void initBoardShopCharacterPreview(void);
+void initBoardShopCharacterTransition(void);
+void initBoardShopColumnSelectorArrow(void);
+void initBoardShopComparisonIcons(void);
+void initBoardShopExitOverlay(void);
+void initBoardShopPreviewWipe(void);
+void initBoardShopRowSelectorArrow(void);
+void initBoardShopShopkeeper(void);
+void initBoardShopSnowParticles(void);
+void initBoardShopSnowflakeSlideIn(void);
+void initBoardShopTitleCorners(void);
+void initBoardShopTitleText(void);
+void loadBoardShopBackground(void);