Skip to content

Commit 5485d8e

Browse files
authored
chore: require php 8.3+ (#153)
1 parent 84e05bf commit 5485d8e

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Install PHP
1919
uses: shivammathur/setup-php@v2
2020
with:
21-
php-version: 8.2
21+
php-version: 8.3
2222
coverage: none
2323
extensions: json
2424
tools: cs2pr
@@ -41,7 +41,7 @@ jobs:
4141
- name: Install PHP
4242
uses: shivammathur/setup-php@v2
4343
with:
44-
php-version: 8.2
44+
php-version: 8.3
4545
coverage: none
4646
extensions: json
4747
tools: cs2pr
@@ -59,14 +59,13 @@ jobs:
5959
strategy:
6060
matrix:
6161
php-version:
62-
- "8.2"
6362
- "8.3"
6463
- "8.4"
6564
dependencies:
6665
- "highest"
6766
include:
6867
- dependencies: "lowest"
69-
php-version: "8.2"
68+
php-version: "8.3"
7069
name: PHP ${{ matrix.php-version }} Test ${{ matrix.dependencies }}
7170

7271
steps:

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
}
1515
},
1616
"require": {
17-
"php": "^8.2",
17+
"php": "^8.3",
1818
"doctrine/coding-standard": "^12.0",
1919
"slevomat/coding-standard": "^8.15",
2020
"squizlabs/php_codesniffer": "^3.11.2"

tests/Sniffs/NamingConventions/ValidConstantNameSniffTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
use function json_encode;
1313

1414
use const JSON_THROW_ON_ERROR;
15-
use const PHP_VERSION_ID;
1615

1716
#[CoversClass(ValidConstantNameSniff::class)]
1817
class ValidConstantNameSniffTest extends TestCase
@@ -45,10 +44,6 @@ public function testErrors(): void
4544

4645
public function testErrorsConstantType(): void
4746
{
48-
if (PHP_VERSION_ID < 80300) {
49-
self::markTestSkipped('Test requires PHP 8.3');
50-
}
51-
5247
$file = self::checkFile(__DIR__ . '/data/ValidConstantNameWithTypeTest.inc');
5348

5449
$errorTypesPerLine = [

0 commit comments

Comments
 (0)