Minor things

The change in `parseBackground()` is an oversight in 7b0acf5 and fixes a global
variable declaration that did not throw an error before, because Jest runs
tests in non-strict mode, even if the implementation is written with ES modules
(which are interpreted in strict mode by default).

Author: cdoublev

lib/parse/postprocess.js

@@ -5,6 +5,7 @@ import * as dimensions from '../values/dimensions.js'
 import * as pseudos from '../values/pseudos.js'
 import { add as addTypes, dimensionTypes, getCalculationType, matchNumericType } from './types.js'
 import { angle, filter, keyword, list, map, number, omitted, string } from '../values/value.js'
+import { auto, notAll } from '../values/defaults.js'
 import { findFunction, findSibling, getDeclaration, getDeclarationName, getFunctionName, getRule, getRuleName, isDeclaredBy, isProducedBy } from '../utils/context.js'
 import { getDeclarationDefinition, parseDeclarationValue, parseGrammar } from './parser.js'
 import { isBlock, isCalculation, isComputationallyIndependent, isFailure, isFunction, isList, isOmitted, isWhitespace } from '../utils/value.js'
@@ -14,7 +15,6 @@ import { create as createError } from '../error.js'
 import { keywords as cssWideKeywords } from '../values/substitutions.js'
 import descriptors from '../descriptors/definitions.js'
 import features from '../values/features.js'
-import { notAll } from '../values/defaults.js'
 import { serializeComponentValue } from '../serialize.js'
 import { simplifyCalculation } from './simplify.js'
 import types from '../values/definitions.js'
@@ -1575,7 +1575,7 @@ function postParseRadialSize(size, node) {
  */
 function postParseRandom({ value: [options,, min,, max,, step], ...props }) {
     if (isOmitted(options)) {
-        options = list([keyword('auto'), omitted], ' ', ['<random-value-sharing>'])
+        options = list([auto, omitted], ' ', ['<random-value-sharing>'])
     }
     return { ...props, value: list([options, min, max, step], ',') }
 }

lib/parse/shorthand.js

@@ -121,7 +121,7 @@ function parseAnimationRangeValue(boundaries, endType) {
 }
 
 /**
- * @param {object[][]} layers
+ * @param {object[][]} backgrounds
  * @param {string[]} longhands
  * @param {string[]} resetOnly
  * @returns {Map}
@@ -130,8 +130,8 @@ function parseAnimationRangeValue(boundaries, endType) {
  * It assigns each background layer value to the corresponding longhand values,
  * setting an omitted `background-clip` value to the `background-origin` value.
  */
-function parseBackground(layers, longhands, resetOnly) {
-    [layers,, final] = layers
+function parseBackground(backgrounds, longhands, resetOnly) {
+    let [layers,, final] = backgrounds
     const color = final.pop()
     const declarations = new Map(longhands.map(longhand =>
         longhand === 'background-color'

lib/serialize.js

@@ -1051,7 +1051,7 @@ function serializeKeyframeSelector(selector) {
  * @returns {string}
  * @see {@link https://drafts.csswg.org/css-grid-2/#typedef-line-names}
  *
- * It serializes empty line name list to empty string (browser conformance).
+ * It serializes an empty line name list to empty string (browser conformance).
  */
 function serializeLineNames(names, allowEmpty) {
     if (names.value.length === 0) {

scripts/extract.js

@@ -630,8 +630,8 @@ const excluded = {
     },
 }
 
-const descriptors = [...Object.keys(initial.descriptors).map(rule => [rule, Object.entries(initial.descriptors[rule])])]
-const properties = [...Object.entries(initial.properties)]
+const descriptors = Object.keys(initial.descriptors).map(rule => [rule, Object.entries(initial.descriptors[rule])])
+const properties = Object.entries(initial.properties)
 const types = [...Object.entries(initial.types), ...Object.entries(replaced.types)]
 
 // TODO: periodically review this list to remove errors that no longer occur

test/stylesheet.js

@@ -394,15 +394,6 @@ describe('CSSRuleList.item()', () => {
         assert.equal(cssRules.item(2), null)
     })
 })
-describe('CSSRuleList.length', () => {
-    it('returns the length of the rule list', () => {
-        const { cssRules } = createStyleSheet(`
-            #rule-1 {}
-            #rule-2 {}
-        `)
-        assert.equal(cssRules.length, 2)
-    })
-})
 
 describe('CSSColorProfileRule', () => {
     test('properties', () => {