chore: revert changes to the creation of the codepipeline_policy resource (having an inline policy should work fine) (#1261)

Author: craigzour

aws/modules/code_pipeline/codebuild.tf

@@ -44,7 +44,7 @@ resource "aws_codebuild_project" "ecs_render" {
     ]
   }
 
-  depends_on = [aws_iam_role_policy_attachment.codepipeline_policy]
+  depends_on = [aws_iam_role_policy.codepipeline_policy]
 }
 
 locals {

aws/modules/code_pipeline/iam.tf

@@ -30,9 +30,9 @@ resource "aws_iam_role_policy_attachment" "AWSCodeDeployRoleForECS" {
   role       = aws_iam_role.this.name
 }
 
-resource "aws_iam_policy" "codepipeline_policy" {
+resource "aws_iam_role_policy" "codepipeline_policy" {
   name   = "codepipeline_policy"
-  path   = "/"
+  role   = aws_iam_role.this.id
   policy = data.aws_iam_policy_document.codepipeline_policy.json
 }
 
@@ -200,8 +200,3 @@ data "aws_iam_policy_document" "codepipeline_policy" {
     }
   }
 }
-
-resource "aws_iam_role_policy_attachment" "codepipeline_policy" {
-  role       = aws_iam_role.this.name
-  policy_arn = aws_iam_policy.codepipeline_policy.arn
-}