Feat/enhance sns payload processing (#952)

* feat: isolate AWS SNS payload processing

* refactor: update AWS SNS payload tests to use aws_sns module

* fix: rename test modules to match target modules

* fix: correct import path for AWS SNS payload processing

* feat: isolate each SNS notification func into pattern handlers

* test: enhance validation tests for AwsNotificationPattern

* feat: add validation for Slack block structures and enhance error handling in AWS SNS notification processing

* feat: add Slack Block Kit utilities and validation

* fix: remove init file from tests directory

* fix: reorder import statements in test_main.py

* Update app/tests/modules/webhooks/patterns/aws_sns_notifications/test_budget_notification.py

Co-authored-by: Copilot <[email protected]>

* Update app/tests/modules/webhooks/patterns/aws_sns_notifications/test_abuse_notification.py

Co-authored-by: Copilot <[email protected]>

* fix: enhance validation for section and header blocks

* fix: add logging for skipped revoke_api_key in non-production environments

---------

Co-authored-by: Copilot <[email protected]>

Author: gcharest

app/integrations/notify/client.py

@@ -98,6 +98,10 @@ def post_event(url, payload):
 def revoke_api_key(api_key, api_type, github_repo, source):
     """Function to revoke an api key by calling Notify's revoke api endpoint"""
     # get the url and jwt_token
+
+    if not settings.is_production:
+        logger.info("revoke_api_key_skipped", api_key=api_key)
+        return False
     url = NOTIFY_API_URL
 
     if url is None:

app/integrations/slack/__init__.py

@@ -5,4 +5,5 @@
 - channels: Module containing the channel related functionality for the Slack integration.
 - users: Module containing the user related functionality for the Slack integration.
 - commands: Module containing the command related functionality for the Slack integration.
+- blocks: Module containing Slack Block Kit utilities and validation.
 """

app/integrations/slack/blocks.py

@@ -0,0 +1,119 @@
+"""Slack Block Kit utilities and validation.
+
+This module provides utilities for working with Slack Block Kit elements,
+including validation and construction helpers.
+"""
+
+from typing import Dict, List
+
+
+def validate_blocks(blocks: List[Dict]) -> bool:
+    """
+    Validate that the provided blocks are valid Slack Block Kit structures.
+
+    This performs basic structural validation to catch common errors before
+    sending blocks to the Slack API. It's not exhaustive but covers the most
+    common block types and their required fields.
+
+    Args:
+        blocks: List of Slack block dictionaries to validate
+
+    Returns:
+        bool: True if blocks are structurally valid, False otherwise
+
+    Examples:
+        >>> blocks = [
+        ...     {"type": "section", "text": {"type": "mrkdwn", "text": "Hello"}},
+        ...     {"type": "divider"}
+        ... ]
+        >>> validate_blocks(blocks)
+        True
+
+        >>> invalid_blocks = [{"text": "missing type"}]
+        >>> validate_blocks(invalid_blocks)
+        False
+    """
+    if not isinstance(blocks, list):
+        return False
+
+    for block in blocks:
+        if not isinstance(block, dict):
+            return False
+
+        if "type" not in block:
+            return False
+
+        # Basic validation for common block types
+        block_type = block.get("type")
+
+        # Section blocks require text OR fields
+        if block_type == "section" and "text" not in block and "fields" not in block:
+            return False
+
+        # Header blocks require text
+        if block_type == "header" and "text" not in block:
+            return False
+
+        # Divider blocks should be minimal
+        if block_type == "divider" and len(block) > 1:
+            return False
+
+        # Actions blocks require elements
+        if block_type == "actions" and "elements" not in block:
+            return False
+
+        # Context blocks require elements
+        if block_type == "context" and "elements" not in block:
+            return False
+
+    return True
+
+
+def create_section_block(text: str, text_type: str = "mrkdwn") -> Dict:
+    """
+    Create a section block with the given text.
+
+    Args:
+        text: The text content for the section
+        text_type: The text type, either 'mrkdwn' or 'plain_text'
+
+    Returns:
+        Dict: A valid Slack section block
+    """
+    return {"type": "section", "text": {"type": text_type, "text": text}}
+
+
+def create_header_block(text: str) -> Dict:
+    """
+    Create a header block with the given text.
+
+    Args:
+        text: The text content for the header
+
+    Returns:
+        Dict: A valid Slack header block
+    """
+    return {"type": "header", "text": {"type": "plain_text", "text": text}}
+
+
+def create_divider_block() -> Dict:
+    """
+    Create a divider block.
+
+    Returns:
+        Dict: A valid Slack divider block
+    """
+    return {"type": "divider"}
+
+
+def create_context_block(elements: List[Dict]) -> Dict:
+    """
+    Create a context block with the given elements.
+
+    Args:
+        elements: List of text or image elements for the context
+
+    Returns:
+        Dict: A valid Slack context block
+    """
+    return {"type": "context", "elements": elements}