You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue mirrors task-61 in this repository's Backlog.md backlog, which is the source of truth for planned work.
Comments are welcome and read by maintainers; the issue body is overwritten on every sync.
Description
Aligns with decisions/approvals.md and decisions/events.md. Refactor app/packages/access/request to consume the generic ApprovalWorkflowService (TASK for infrastructure/approvals extraction) by supplying access-specific ApprovalPolicy and EffectHandler strategies, and retire the two mis-routed mechanisms it currently relies on.
Desired end state:
access/request holds only access-specific policy + effect strategies (approver resolution, thresholds, the grant/revoke effect); all generic workflow machinery comes from infrastructure/approvals.
The access/sync completion hand-off (SYNC_COMPLETED / SYNC_FAILED) that today advances the request via the in-process event bus is reclassified as a workflow step and delivered over the outbox / QueueService (TASK-34) — a durable step, not an event.
The operator-alert notification ('no approvers found') is rehomed onto the notifications capability (TASK-32), not the event bus.
Behavior is preserved end to end (submit -> approve -> grant, rejection, expiry, sync-driven advance).
Depends on the approvals capability extraction, the QueueService/outbox (TASK-34), and the notifications capability (TASK-32). The task-planner agent must assess feasibility as one PR vs decomposition into incremental subtasks that keep the live access flow green throughout.
Acceptance Criteria
access/request supplies only access-specific ApprovalPolicy + EffectHandler; all generic workflow machinery comes from infrastructure/approvals
SYNC_COMPLETED/SYNC_FAILED advance is reclassified as a durable workflow step delivered over the outbox/QueueService, not the event bus
The 'no approvers found' operator alert is rehomed onto the notifications capability, not the event bus
Submit -> approve -> grant, rejection, expiry, and sync-driven advance all behave as before (tests green)
Definition of Done
No access-request logic flows through the in-process event dispatcher
Note
This issue mirrors
task-61in this repository's Backlog.md backlog, which is the source of truth for planned work.Comments are welcome and read by maintainers; the issue body is overwritten on every sync.
Description
Aligns with decisions/approvals.md and decisions/events.md. Refactor app/packages/access/request to consume the generic ApprovalWorkflowService (TASK for infrastructure/approvals extraction) by supplying access-specific ApprovalPolicy and EffectHandler strategies, and retire the two mis-routed mechanisms it currently relies on.
Desired end state:
Depends on the approvals capability extraction, the QueueService/outbox (TASK-34), and the notifications capability (TASK-32). The task-planner agent must assess feasibility as one PR vs decomposition into incremental subtasks that keep the live access flow green throughout.
Acceptance Criteria
Definition of Done
Dependencies
task-60)task-34)task-32)References