fix deprecated datetime.utcnow() and pytest return warnings

Author: cdump

investments/data_providers/cbr.py

@@ -62,7 +62,7 @@ def _fetch_currency_rates(self, currency: Currency):
             self._frames_loaded[frame_key] = df
             return
 
-        end_date = (datetime.datetime.utcnow() + datetime.timedelta(days=1)).strftime('%d/%m/%Y')
+        end_date = (datetime.datetime.now(datetime.UTC) + datetime.timedelta(days=1)).strftime('%d/%m/%Y')
         r = requests.get(f'http://www.cbr.ru/scripts/XML_dynamic.asp?date_req1=01/01/{self._year_from}&date_req2={end_date}&VAL_NM_RQ={currency.cbr_code}', timeout=10)
 
         tree = ET.fromstring(r.text)
@@ -77,7 +77,7 @@ def _fetch_currency_rates(self, currency: Currency):
 
         df = pandas.DataFrame(rates_data, columns=['date', 'rate'])
         df.set_index(['date'], inplace=True)
-        today = datetime.datetime.utcnow().date()
+        today = datetime.datetime.now(datetime.UTC).date()
         df = df.reindex(pandas.date_range(df.index.min(), today))
         df['rate'] = df['rate'].ffill()
 

tests/ibtax/prepare_trades_report_test.py

@@ -7,7 +7,7 @@
 from investments.money import Money
 from investments.ticker import Ticker, TickerKind
 from investments.trades_fifo import FinishedTrade
-from tests.trades_fifo_test import test_trades_precision
+from tests.trades_fifo_test import get_trades_precision_testcase
 
 
 def test_simple_trades():
@@ -83,7 +83,7 @@ def test_precision():
 
     """
 
-    test_case = test_trades_precision()
+    test_case = get_trades_precision_testcase()
 
     res: dict = prepare_trades_report(test_case, ExchangeRatesRUB()).to_dict()
 

tests/trades_fifo_test.py

@@ -99,7 +99,7 @@ def test_trades_fees_simple() -> None:
     assert sell_trade.fee_per_piece.amount == Decimal('-0.101812674')
 
 
-def test_trades_precision() -> List[FinishedTrade]:
+def get_trades_precision_testcase() -> List[FinishedTrade]:
     ticker = Ticker(symbol='VT', kind=TickerKind.Stock)
     test_case = [
         Trade(
@@ -120,7 +120,11 @@ def test_trades_precision() -> List[FinishedTrade]:
         )
     ]
 
-    finished_trades = TradesAnalyzer(test_case).finished_trades
+    return TradesAnalyzer(test_case).finished_trades
+
+
+def test_trades_precision():
+    finished_trades = get_trades_precision_testcase()
 
     buy_trade: FinishedTrade = finished_trades[0]
     assert buy_trade.price.amount == Decimal('80.62')
@@ -129,5 +133,3 @@ def test_trades_precision() -> List[FinishedTrade]:
     sell_trade: FinishedTrade = finished_trades[1]
     assert sell_trade.price.amount == Decimal('81.82')
     assert sell_trade.fee_per_piece.amount == Decimal('-0.101812674')
-
-    return finished_trades