Tree: propagation channels shouldn't update Task rc

Use a temporary fix to avoid the gateways to update Task's rc dict. The
permanent fix will be to clean this mess with Task Event Handlers (see
at least #369 and #231).

Change-Id: I2049a4b6ce3931f1b245b29326ba3daa065b36ba

Author: thiell

lib/ClusterShell/Task.py

@@ -1318,6 +1318,7 @@ def _pchannel(self, gateway, metaworker):
             wrkcls = self.default('distant_worker')
             chanworker = wrkcls(gateway, command=metaworker.invoke_gateway,
                                 handler=chan, stderr=True, timeout=timeout)
+            chanworker._update_task_rc = False
             # gateway is special! define worker._fanout to not rely on the
             # engine's fanout, and use the special value FANOUT_UNLIMITED to
             # always allow registration of gateways

lib/ClusterShell/Worker/Worker.py

@@ -110,6 +110,10 @@ def __init__(self, handler):
         # cannot currently be changed afterwards.
         self._fanout = FANOUT_DEFAULT
 
+        # Update task rc? [private]
+        # TODO: to be replaced with Task Event Handlers
+        self._update_task_rc = True
+
         # Parent task (once bound)
         self.task = None            #: worker's task when scheduled or None
         self.started = False        #: set to True when worker has started
@@ -155,10 +159,11 @@ def _on_start(self, key):
 
     def _on_close(self, key, rc=None):
         """Called to generate events when the Worker is closing."""
-        # rc may be None here for example when called from StreamClient
-        # Only update task if rc is not None.
-        if rc is not None:
-            self.task._rc_set(self, key, rc)
+        if self._update_task_rc:
+            # rc may be None here for example when called from StreamClient
+            # Only update task if rc is not None.
+            if rc is not None:
+                self.task._rc_set(self, key, rc)
 
         self.current_node = key
         self.current_rc = rc

tests/TreeTaskTest.py

@@ -37,8 +37,7 @@ def test_shell_auto_tree_dummy(self):
 
         self.assertRaises(RouteResolvingError, task.run, "/bin/hostname",
                           nodes="dummy-node", stderr=True)
-        # FIXME: should probably be None
-        self.assertEqual(task.max_retcode(), 255)
+        self.assertEqual(task.max_retcode(), None)
 
     def test_shell_auto_tree_noconf(self):
         """test task shell auto tree [no topology.conf]"""