CLI/Error: add error handling for malformed groups.conf (#379)

Handle configparser's exceptions in case of malformed clush.conf or
groups.conf.

Closes #379

Change-Id: Iffa3bf3f425affefd976a4c4f252a3dcee7fda1a

Author: thiell

lib/ClusterShell/CLI/Error.py

@@ -23,6 +23,12 @@
 
 from __future__ import print_function
 
+try:
+    import configparser
+except ImportError:
+    # Python 2 compat
+    import ConfigParser as configparser
+
 import errno
 import logging
 import os.path
@@ -42,7 +48,8 @@
 from ClusterShell.Worker.EngineClient import EngineClientError
 from ClusterShell.Worker.Worker import WorkerError
 
-GENERIC_ERRORS = (EngineNotSupportedError,
+GENERIC_ERRORS = (configparser.Error,
+                  EngineNotSupportedError,
                   EngineClientError,
                   NodeSetExternalError,
                   NodeSetParseError,
@@ -88,6 +95,8 @@ def handle_generic_error(excobj, prog=os.path.basename(sys.argv[0])):
         print("%s: Group error: %s" % (prog, exc), file=sys.stderr)
     except TopologyError as exc:
         print("%s: TREE MODE: %s" % (prog, exc), file=sys.stderr)
+    except configparser.Error as exc:
+        print("%s: %s" % (prog, exc), file=sys.stderr)
     except (TypeError, WorkerError) as exc:
         print("%s: %s" % (prog, exc), file=sys.stderr)
     except (IOError, OSError) as exc:  # see PEP 3151

tests/CLINodesetTest.py

@@ -823,3 +823,19 @@ def tearDown(self):
     def test_empty_groups_conf(self):
         """test nodeset with empty groups.conf"""
         self._nodeset_t(["--list-all"], None, b"")
+
+
+class CLINodesetMalformedGroupsConf(CLINodesetTestBase):
+    """Unit test class for testing malformed groups.conf"""
+
+    def setUp(self):
+        self.gconff = make_temp_file(b"[Main")
+        set_std_group_resolver(GroupResolverConfig(self.gconff.name))
+
+    def tearDown(self):
+        set_std_group_resolver(None)
+        self.gconff = None
+
+    def test_malformed_groups_conf(self):
+        """test nodeset with malformed groups.conf"""
+        self._nodeset_t(["--list-all"], None, b"", 1, b"'[Main'\n")