Skip to content

Commit 1119a19

Browse files
committed
run: simplify if merge logic
Make error buffer a copy of the output buffer reference when merged to skip if/else logic when handling output.
1 parent 55ec3c7 commit 1119a19

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

lib/rift/run.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,9 @@ def run_command(
100100
# Initialize string buffers to store process output in memory
101101
buf_out = io.StringIO()
102102
buf_err = None
103-
if not merge_out_err:
103+
if merge_out_err:
104+
buf_err = buf_out
105+
else:
104106
buf_err = io.StringIO()
105107

106108
# Process output lines handlers
@@ -111,10 +113,7 @@ def handle_stdout(stream):
111113
sys.stdout.write(line)
112114
def handle_stderr(stream):
113115
line = stream.readline()
114-
if merge_out_err:
115-
buf_out.write(line)
116-
else:
117-
buf_err.write(line)
116+
buf_err.write(line)
118117
if live_output:
119118
sys.stderr.write(line)
120119

@@ -133,10 +132,7 @@ def handle_stderr(stream):
133132
if live_output:
134133
sys.stdout.write(line)
135134
for line in process.stderr:
136-
if merge_out_err:
137-
buf_out.write(line)
138-
else:
139-
buf_err.write(line)
135+
buf_err.write(line)
140136
if live_output:
141137
sys.stdout.write(line)
142138

0 commit comments

Comments
 (0)