Skip to content

Update to lalrpop 0.23.0 or higherย #2209

@katherine-hough

Description

@katherine-hough

Describe the improvement you'd like to request

The lalrpop upgrade to 0.23.0 breaks the build-cedar-java workflow:

error: couldn't read `/home/runner/work/cedar/cedar/CedarJavaFFI/target/x86_64-pc-windows-gnu/release/build/cedar-policy-core-09e5411d160de982/out\/parser/grammar.rs`: No such file or directory (os error 2)
  --> /home/runner/work/cedar/cedar/cedar/cedar-policy-core/src/parser/text_to_cst.rs:20:1

The root cause appears to be this change: lalrpop/lalrpop@8aeb070. Cedar-java cross-compiles to x86_64-pc-windows-gnu, and #[cfg(target_os = "windows")] looks at the target OS not the host OS resulting in the wrong path separator being used.

We have opened an issue on lalrpop for this behavior.
When this issue is fixed, we should upgrade lalrpop and remove the entry ignoring updates to lalrpop from .github/dependabot.yml.

Describe alternatives you've considered

No response

Additional context

Not upgrading lalrpop.

Is this something that you'd be interested in working on?

  • ๐Ÿ‘‹ I may be able to implement this internal improvement
  • โš ๏ธ This feature might incur a breaking change

Metadata

Metadata

Assignees

No one assigned

    Labels

    internal-improvementRefactoring, minor performance improvement, or other changes that Cedar users may never notice

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions