generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 135
Open
Labels
internal-improvementRefactoring, minor performance improvement, or other changes that Cedar users may never noticeRefactoring, minor performance improvement, or other changes that Cedar users may never notice
Description
Describe the improvement you'd like to request
The lalrpop upgrade to 0.23.0 breaks the build-cedar-java workflow:
error: couldn't read `/home/runner/work/cedar/cedar/CedarJavaFFI/target/x86_64-pc-windows-gnu/release/build/cedar-policy-core-09e5411d160de982/out\/parser/grammar.rs`: No such file or directory (os error 2)
--> /home/runner/work/cedar/cedar/cedar/cedar-policy-core/src/parser/text_to_cst.rs:20:1
The root cause appears to be this change: lalrpop/lalrpop@8aeb070. Cedar-java cross-compiles to x86_64-pc-windows-gnu, and #[cfg(target_os = "windows")] looks at the target OS not the host OS resulting in the wrong path separator being used.
We have opened an issue on lalrpop for this behavior.
When this issue is fixed, we should upgrade lalrpop and remove the entry ignoring updates to lalrpop from .github/dependabot.yml.
Describe alternatives you've considered
No response
Additional context
Not upgrading lalrpop.
Is this something that you'd be interested in working on?
- ๐ I may be able to implement this internal improvement
-
โ ๏ธ This feature might incur a breaking change
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
internal-improvementRefactoring, minor performance improvement, or other changes that Cedar users may never noticeRefactoring, minor performance improvement, or other changes that Cedar users may never notice