fix: validate random_int parameters in Helper::randomPort to prevent min > max error

xboard · xboard · commit fad6441f4c85 · 2026-03-09T06:32:10.000+08:00
diff --git a/app/Utils/Helper.php b/app/Utils/Helper.php
@@ -142,8 +142,13 @@ public static function getSubscribeUrl(string $token, $subscribeUrl = null)
     }
 
     public static function randomPort($range): int {
-        $portRange = explode('-', $range);
-        return random_int((int)$portRange[0], (int)$portRange[1]);
+        $portRange = explode('-', (string) $range, 2);
+        $min = (int) ($portRange[0] ?? 0);
+        $max = (int) ($portRange[1] ?? $portRange[0] ?? 0);
+        if ($min > $max) {
+            [$min, $max] = [$max, $min];
+        }
+        return random_int($min, $max);
     }
 
     public static function base64EncodeUrlSafe($data)

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,13 @@ public static function getSubscribeUrl(string $token, $subscribeUrl = null)`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`public static function randomPort($range): int {`
`145`		`- $portRange = explode('-', $range);`
`146`		`- return random_int((int)$portRange[0], (int)$portRange[1]);`
	`145`	`+ $portRange = explode('-', (string) $range, 2);`
	`146`	`+ $min = (int) ($portRange[0] ?? 0);`
	`147`	`+ $max = (int) ($portRange[1] ?? $portRange[0] ?? 0);`
	`148`	`+ if ($min > $max) {`
	`149`	`+ [$min, $max] = [$max, $min];`
	`150`	`+ }`
	`151`	`+ return random_int($min, $max);`
`147`	`152`	`}`
`148`	`153`
`149`	`154`	`public static function base64EncodeUrlSafe($data)`