1500 fix unit tests #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 13, 2021 13:21
…mentation) to take dictionary with extra parameters allowed as well as methods within this class not to reference config but the variable that was set. Adjusted effected tests.
…WebPublisher_unit as unit test until create folder structure for integration vs unit tests.
…o take dictionary with extra parameters allowed as well as methods within this class not to reference config but the variable that was set. Adjusted effected tests.
… to take dictionary with extra parameters allowed as well as methods within this class not to reference config but the variable that was set. Adjusted effected tests. Removed get_logger method as it wasn't used and we used a different logger then. Added checks for if security wasn't enabled.
… using a topic variable instead. Removed changing name of the consumer_conf to meta_consumer_conf. Added additional logging.
… clearer how similar code is to KafkaPublisher class.
…ould notice this usage).
…) to take dictionary with extra parameters allowed as well as methods within this class not to reference config but the variable that was set. Removed logging import and changed to ClientLogger.
…es sense. Added test for extra arguments via constructor. Fixed test for testing less parameters passed in, because more could have made it through.
…rn values a little better where could, and changed a test of assertTrue to assertEqual so got to see what the actual value was when failed.
…olidate generating the key from UUID, and added a little logging. Consolidated topic generation code too.
… file_id_prefix as it is in half the other places including S3MessageAdapter constructor.
…tra parameters allowed. Refactored out of SqsConsumer the connecting part and put into S3Utils, this left only log_level as class var. Put creating a Queue object into receive_messages (can refactor out if ever need again, but single line didn't seem to warrent its own method). Added debug logging.
…arameters for receive_message so a user could create their own queue or use our connect to do so and pass either in.
… with extra parameters allowed so adjusted the tests and added more with more verification.
…usted SqsConsumer callback parameters to pass along log_level.
added 20 commits
May 11, 2021 09:25
…us assuming if they say "glacier" they mean a client of service type "glacier". Little clearer to the user and in the code. This allows boto to catch the error of wrong service name specified and it gives a nice list of choices. Added else statement too for cases user specifies a type we don't expect, will add tests to.
… a moto version issue. getmoto/moto#3297
…of an error to warning.
…tegration. Change circle ci config to run all onestop-python-client tests.
…ved some blank lines from S3Utils.
…ld one. Trying to figure out how to force it to a newer one.
…nflict between botocore 1.18.11 and moto 2.0.5
… using my local aws config when region was not specified.
… to install boto for pip3 every time.
…iables if credentials yml doesn't exist. Commented out integration task in circleCI config. Since cannot reach registry on cedardevs.
…credentials template.
…le _topic_produce to _topic_publish, as it is in the constructor for KafkaPublisher and KafkaConsumer.
…exception. Otherwise wasn't evaluating the variable within message.
…asn't printing value of variable. Added test for that negative case.
…multiplied instead of divided to get seconds.
…realize was used, looked obsolete.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.