Indexable datetime checks absolute value - catch for bad data

Author: zebdelk

schemas-analyze/src/main/java/org/cedar/schemas/analyze/Temporal.java

@@ -127,7 +127,7 @@ static boolean indexable(Long year) {
     // this number is a bit arbitrary, and prone to change when ES switches to the Java time library (minimum supported year
     // being -999,999,999). We will limit the year ourselves instead to -100,000,000 -- since this is a fairly safe bet for
     // supportability across many date libraries if the utcDateTime ends up used as is by a downstream app.
-    return year >= -100_000_000L;
+    return Math.abs(year) <= 100_000_000L;
   }
 
   static String precision(TemporalAccessor date) {

schemas-analyze/src/test/groovy/org/cedar/schemas/analyze/DateInfoSpec.groovy

@@ -71,6 +71,7 @@ class DateInfoSpec extends Specification {
     '-3000'                | false || ValidDescriptor.VALID     | 'Years'   | true      | null | '-3000-12-31T23:59:59.999Z'
     '-100000001'           | true  || ValidDescriptor.VALID     | 'Years'   | false     | null | '-100000001-01-01T00:00:00Z'
     '-100000002'           | false || ValidDescriptor.VALID     | 'Years'   | false     | null | '-100000002-12-31T23:59:59.999Z'
+    '100000002'            | false || ValidDescriptor.VALID     | 'Years'   | false     | null | '100000002-12-31T23:59:59.999Z'
     'ABC'                  | true  || ValidDescriptor.INVALID   | null      | false     | null | null
     ''                     | true  || ValidDescriptor.UNDEFINED | null      | true      | null | null
     null                   | true  || ValidDescriptor.UNDEFINED | null      | true      | null | null