Skip to content

Commit 70e7f20

Browse files
committed
Merge branch 'master' into error-event
2 parents 90fdbc1 + a443416 commit 70e7f20

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

schemas-parse/src/main/java/org/cedar/schemas/parse/DefaultParser.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class DefaultParser {
1313
* Given a {@link ParsedRecord}, fill in any empty fields for which a default can be calculated. For instance
1414
* if the record's {@link Discovery} does not have a title, it will be set with the default, which is the the
1515
* {@link FileInformation#getName()} (see: {@link #defaultTitle(ParsedRecord.Builder)}).
16-
* <br/>
16+
* <br>
1717
* In general, only fields which have no value will be set with their defaults. The exception is the links,
1818
* which will have the defaults merged into the input values, with inputs taking precedence.
1919
* See: {@link #setDefaultLinks(ParsedRecord.Builder)}
@@ -278,15 +278,15 @@ private static boolean discoveryListEmpty(ParsedRecord.Builder builder, Function
278278

279279
/**
280280
* <em>IMPORTANT!!</em>
281-
* <br/>
281+
* <br>
282282
* Apparently functions on an Avro builder which return a builder for a nested object,
283283
* for example {@link ParsedRecord.Builder#getDiscoveryBuilder}, are not always null-safe!
284-
* <br/>
284+
* <br>
285285
* If that nested object is nullable, and you built the {@code ParsedRecord} builder from another {@code ParsedRecord}
286286
* instance with {@link ParsedRecord#newBuilder(ParsedRecord)}, then it'll set {@code null} as the value
287287
* for the {@code Discovery} object, which will cause {@link ParsedRecord.Builder#hasDiscovery()} to return {@code true}
288288
* since the {@code Discovery} object was technically set (even though it was set to {@code null}).
289-
* <br/>
289+
* <br>
290290
* The result in that case is that {@link ParsedRecord.Builder#getDiscoveryBuilder()} throws a {@link NullPointerException}.
291291
* This function will check whether the {@code Discovery} is null and create a {@code Discovery.Builder} safely.
292292
*

0 commit comments

Comments
 (0)