-
Notifications
You must be signed in to change notification settings - Fork 2
sample using accelerated renderer in offscreen environment #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AzeExMachina
wants to merge
3
commits into
cefsharp:main
Choose a base branch
from
AzeExMachina:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -397,3 +397,4 @@ FodyWeavers.xsd | |
| # JetBrains Rider | ||
| *.sln.iml | ||
| /CefSharp.WinForms.Direct3D.Example/obj.netcore | ||
| .idea/ | ||
42 changes: 42 additions & 0 deletions
42
CefSharp.Offscreen.Direct3D.Example/AcceleratedRenderHandler.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| using CefSharp.OffScreen; | ||
| using CefSharp.Structs; | ||
|
|
||
| namespace CefSharp.Offscreen.Direct3D.Example; | ||
|
|
||
| public class AcceleratedRenderHandler(ChromiumWebBrowser browser, int windowWidth, int windowHeight) : DefaultRenderHandler(browser) | ||
| { | ||
| private D3D11Renderer _renderer = null!; | ||
|
|
||
| public override void OnAcceleratedPaint(PaintElementType type, Rect dirtyRect, AcceleratedPaintInfo acceleratedPaintInfo) | ||
| { | ||
| base.OnAcceleratedPaint(type, dirtyRect, acceleratedPaintInfo); | ||
| _renderer ??= new D3D11Renderer(windowWidth, windowHeight); | ||
| switch (type) | ||
| { | ||
| case PaintElementType.View: | ||
| _renderer?.OnAcceleratedPaint(acceleratedPaintInfo.SharedTextureHandle, PopupOpen); | ||
| break; | ||
| case PaintElementType.Popup: | ||
| _renderer?.CreatePopupLayer(acceleratedPaintInfo.SharedTextureHandle, new Rect(PopupPosition.X, PopupPosition.Y, PopupSize.Width, PopupSize.Height)); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| public void BrowserWasResized(int width, int height) | ||
| { | ||
| _renderer?.ResizeWindow(width, height); | ||
| } | ||
|
|
||
| public override void OnPopupShow(bool show) | ||
| { | ||
| base.OnPopupShow(show); | ||
| if(show) return; | ||
| _renderer?.RemovePopupLayer(); | ||
| } | ||
|
|
||
| public new void Dispose() | ||
| { | ||
| base.Dispose(); | ||
| _renderer?.Dispose(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| namespace CefSharp.Offscreen.Direct3D.Example; | ||
|
|
||
| public class Application | ||
| { | ||
| public static Uri Url { get; set; } = new("https://github.com/cefsharp/CefSharp.OnAcceleratedPaint.Example"); | ||
| private readonly OffscreenBrowser _browser; | ||
| public Application() | ||
| { | ||
| var cefBrowserSettings = new BrowserSettings | ||
| { | ||
| BackgroundColor = Cef.ColorSetARGB(255, 255, 255, 255), | ||
| WebGl = CefState.Enabled, | ||
| WindowlessFrameRate = 60, | ||
| LocalStorage = CefState.Default | ||
| }; | ||
|
|
||
| _browser = new OffscreenBrowser(1920, 1080, Url.AbsoluteUri, cefBrowserSettings); | ||
| } | ||
|
|
||
| public void Close() | ||
| { | ||
| _browser.Stop(); | ||
| _browser.Dispose(); | ||
| Cef.Shutdown(); | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
CefSharp.Offscreen.Direct3D.Example/CefSharp.Offscreen.Direct3D.Example.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>disable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="CefSharp.OffScreen.NETCore" Version="133.4.21" /> | ||
| <PackageReference Include="SharpDX.D3DCompiler" Version="4.2.0" /> | ||
| <PackageReference Include="SharpDX.Direct2D1" Version="4.2.0" /> | ||
| <PackageReference Include="SharpDX.Direct3D11" Version="4.2.0" /> | ||
| <PackageReference Include="SharpDX.Mathematics" Version="4.2.0" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a rider folder containing project specific settings files, it's not mandatory since I simply can avoid to commit that folder. It was just to make it easier when committing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response, should be fine to leave.