Skip to content

Commit 0d15db9

Browse files
committed
BrowserSubProcess - Increase x64/arm64 stack size
- For Net 4.5.2 it appears we need to resign the exe - For .Net Core as the exes are native it doesn't look like we need to sign them (the CefSharp.BrowserSubprocess.dll is actually the one that's signed). - Remove unused CefSharpBrowserSubprocessPostBuildEvent Issue #3986
1 parent 8b9a5e2 commit 0d15db9

File tree

3 files changed

+8
-17
lines changed

3 files changed

+8
-17
lines changed

CefSharp.BrowserSubprocess/CefSharp.BrowserSubprocess.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@
3535
<None Remove="obj.netcore\**" />
3636
</ItemGroup>
3737
<Target Name="PostBuild" AfterTargets="PostBuildEvent">
38-
<Exec Command="if $(PlatformName) == x86 (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars32.bat&quot;&#xD;&#xA; editbin /largeaddressaware /TSAWARE &quot;$(TargetPath)&quot; &#xD;&#xA; sn -R &quot;$(TargetPath)&quot; &quot;$(ProjectDir)..\CefSharp.snk&quot;&#xD;&#xA;) else (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars64.bat&quot;&#xD;&#xA; editbin /TSAWARE &quot;$(TargetPath)&quot;&#xD;&#xA;)" />
38+
<Exec Command="if $(PlatformName) == x86 (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars32.bat&quot;&#xD;&#xA; editbin /largeaddressaware /TSAWARE &quot;$(TargetPath)&quot; &#xD;&#xA; sn -R &quot;$(TargetPath)&quot; &quot;$(ProjectDir)..\CefSharp.snk&quot;&#xD;&#xA;) else (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars64.bat&quot;&#xD;&#xA; editbin /TSAWARE /STACK:0x800000 &quot;$(TargetPath)&quot;&#xD;&#xA; sn -R &quot;$(TargetPath)&quot; &quot;$(ProjectDir)..\CefSharp.snk&quot;&#xD;&#xA;)" />
3939
</Target>
4040
</Project>

CefSharp.BrowserSubprocess/CefSharp.BrowserSubprocess.netcore.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@
5656
<ProjectReference Include="..\CefSharp\CefSharp.netcore.csproj" />
5757
</ItemGroup>
5858

59+
<Target Name="PostBuild" AfterTargets="PostBuildEvent">
60+
<Exec Command="if $(PlatformName) == x86 (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars32.bat&quot;&#xD;&#xA; editbin /largeaddressaware /TSAWARE &quot;$(TargetDir)CefSharp.BrowserSubprocess.exe&quot; &#xD;&#xA;) else if $(PlatformName) == x64 (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars64.bat&quot;&#xD;&#xA; editbin /STACK:0x800000 &quot;$(TargetDir)CefSharp.BrowserSubprocess.exe&quot;&#xD;&#xA;) else if $(PlatformName) == arm64 (&#xD;&#xA; call &quot;$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvarsamd64_arm64.bat&quot;&#xD;&#xA; editbin /STACK:0x800000 &quot;$(TargetDir)CefSharp.BrowserSubprocess.exe&quot;&#xD;&#xA;)&#xD;&#xA;" />
61+
</Target>
62+
5963
<!-- Implicit bottom import -->
6064
<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />
6165
</Project>

CefSharp.props

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,9 @@
99
<PlatformToolset Condition="'$(VisualStudioVersion)'=='17.0'">v143</PlatformToolset>
1010

1111
<!-- TODO: We might need to do something here when VS2019 and VS2022 are installed -->
12-
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
13-
<!-- <WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='16.0'">10.0</WindowsTargetPlatformVersion> -->
14-
<!-- <WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='17.0'">10.0</WindowsTargetPlatformVersion> -->
15-
16-
<CefSharpBrowserSubprocessPostBuildEvent>
17-
<![CDATA[
18-
if $(PlatformName) == x86 (
19-
call "$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars32.bat"
20-
editbin /largeaddressaware /TSAWARE "$(TargetPath)"
21-
sn -R "$(TargetPath)" "$(ProjectDir)..\CefSharp.snk"
22-
) else (
23-
call "$(DevEnvDir)..\..\VC\Auxiliary\Build\vcvars64.bat"
24-
editbin /TSAWARE "$(TargetPath)"
25-
)
26-
]]>
27-
</CefSharpBrowserSubprocessPostBuildEvent>
12+
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
13+
<!-- <WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='16.0'">10.0</WindowsTargetPlatformVersion> -->
14+
<!-- <WindowsTargetPlatformVersion Condition="'$(VisualStudioVersion)'=='17.0'">10.0</WindowsTargetPlatformVersion> -->
2815
</PropertyGroup>
2916

3017
</Project>

0 commit comments

Comments
 (0)